Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: Make .domain on async resources non-enumerable #26210

Closed
wants to merge 1 commit into from
Closed

domain: Make .domain on async resources non-enumerable #26210

wants to merge 1 commit into from

Commits on Feb 20, 2019

  1. domain: set .domain non-enumerable on resources 

    In particular, this comes into play in the node repl, which apparently
enables domains by default. Whenever any Promise gets inspected, a
`.domain` property is displayed, which is *very confusing*, especially
since it has some kind of WeakReference attached to it, which is not yet
a language feature.

This change will prevent it from showing up in casual inspection, but
will leave it available for use.
    @ljharb
    ljharb committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    b1ae6f4 View commit details
    Browse the repository at this point in the history