Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #26383

Closed
wants to merge 7 commits into
base: master
from

Conversation

@addaleax
Copy link
Member

addaleax commented Mar 1, 2019

This was last updated in September, so I think it’s time. :)

@addaleax addaleax added the meta label Mar 1, 2019

Show resolved Hide resolved AUTHORS Outdated
Thang Tran <trankimthang279@gmail.com>
Kai <Schweinepriester@users.noreply.github.com>
Abhishek Agarwal <abhishek.agr31@gmail.com>
Uttam Pawar <upawar@gmail.com>

This comment has been minimized.

@addaleax

addaleax Mar 1, 2019

Author Member

@uttampawar You have committed with two different email addresses – which do you prefer to have listed here?

grimrose <grimrose@users.noreply.github.com>
timothy searcy <timmyzsearcy@gmail.com>
nakashima <nakashima1711@gmail.com>
/Jesse <jesse.katsumata@gmail.com>

This comment has been minimized.

@gengjiawen

gengjiawen Mar 1, 2019

Contributor

is / a redundant here ?

This comment has been minimized.

@addaleax

addaleax Mar 1, 2019

Author Member

This is taken from the git log, from the Author: field – @Naturalclar Which name should we use here? Or should we keep the /?

Show resolved Hide resolved AUTHORS Outdated
AUTHORS Outdated
Mikko Rantanen <jubjub@jubjubnest.net>
wenjun ye <1728914873@qq.com>
briete <briete5814@gmail.com>
Matteo Collina <hello@matteocollina.com>

This comment has been minimized.

@ChALkeR

ChALkeR Mar 2, 2019

Member

I think this is @mcollina?

This comment has been minimized.

@mcollina

This comment has been minimized.

@addaleax

addaleax Mar 2, 2019

Author Member

This was happening because we didn’t have support for .mailmap entries for Co-authored-by: or Author: tags that were manually added to the commit message.

8f2bb03 should remedy that.

Show resolved Hide resolved AUTHORS Outdated

@addaleax addaleax force-pushed the addaleax:update-authors branch from fe28b86 to c967521 Mar 2, 2019

dexterleng <thequicklab@gmail.com>
Kunda Sunil Kumar <kunda.sunilkumar@gmail.com>
rahulshuklab4u <rahulshuklab4u@gmail.com>
gengjiawen <technicalcute@gmail.com>

This comment has been minimized.

@gengjiawen

gengjiawen Mar 2, 2019

Contributor

Back then I am young and simple, now I think my email address is silly 😭

This comment has been minimized.

@addaleax

addaleax Mar 2, 2019

Author Member

@gengjiawen You can always change it for new commits with git config --global user.email foo@bar.com, and you can always choose one for the AUTHORS file if you want? :)

(Also, it’s not silly. 🙂)

This comment has been minimized.

@gengjiawen

gengjiawen Mar 2, 2019

Contributor

Thanks. Maybe later :)

@nodejs nodejs deleted a comment from cclauss Mar 2, 2019

Show resolved Hide resolved .mailmap
Show resolved Hide resolved tools/update-authors.js Outdated
Show resolved Hide resolved tools/update-authors.js Outdated

addaleax added some commits Mar 1, 2019

tools: add mailmap support for Co-authored-by tags
Support `.mailmap` for manually added `Author:` and
`Co-authored-by:` tags.

@addaleax addaleax force-pushed the addaleax:update-authors branch from d4cd064 to 0aeb028 Mar 4, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Mar 4, 2019

@BridgeAR Done, applied your suggestions in 68921c0

David Mark Clements <david.clements@nearform.com> davidmarkclements <huperekchuno@googlemail.com>
David Mark Clements <david.clements@nearform.com>
David Mark Clements <david.clements@nearform.com> <huperekchuno@googlemail.com>
David Mark Clements <david.clements@nearform.com> <david.mark.clements@gmail.com>

This comment has been minimized.

@addaleax

addaleax Mar 4, 2019

Author Member

@davidmarkclements Just confirming, since you’ve been freshly listed with a third email address thanks to b1ef279 – the NearForm one is still the one you use for AUTHORS?

@BridgeAR
Copy link
Member

BridgeAR left a comment

RSLGTM

@ChALkeR

This comment has been minimized.

Copy link
Member

ChALkeR commented Mar 5, 2019

@cclauss, this issue log shows that I deleted your comment here: #26383 (comment):

2019-03-05 5 05 29

I wanted to apologise for that, that comment deletion was not intentional, and I just recently noticed it.

I don't remember deleting a comment here (on a purpose or not), it must have been accidental, most likely while I was commenting on this issue from my phone.

Unfortunately, I do not have the means of restoring a deleted comment or checking what exactly was in that comment (GitHub does not provide that afaik). The only way that I know how it could be restored is if you re-post it from your side.

I really hope that nothing was missed, but in any case — please feel free to restore that comment if you want to.

Sorry again 😞 .

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Mar 5, 2019

Unfortunately, I do not have the means of restoring a deleted comment or checking what exactly was in that comment

Someone who receives email notifications of comments on this issue might have the content.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Mar 5, 2019

this is what I have in mailbox matching to that day and time - the accidentally deleted comment, for the record:

Subject:	Re: [nodejs/node] doc: update AUTHORS list (#26383)
From:	cclauss
To:	nodejs/node, Subscribed
Date:	03/02/2019 07:13 PM
@cclauss commented on this pull request.

In .mailmap:
> @@ -72,6 +73,8 @@ Chew Choon Keat <choonkeat@gmail.com>
 Chris Andrews <cpandrews8@gmail.com> cpandrews8 <cpandrews8@gmail.com>
 Chris Johnson <chris.s.johnson4@gmail.com>
 Chris Young <chris.young@tinder.com> <chris.young@gotinder.com>
+Christian Clauss <cclauss@me.com>

We can keep line 76 and delete line 77.
Show resolved Hide resolved AUTHORS Outdated
@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Mar 5, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 5, 2019

tools: add mailmap support for Co-authored-by tags
Support `.mailmap` for manually added `Author:` and
`Co-authored-by:` tags.

PR-URL: nodejs#26383
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 5, 2019

doc: update AUTHORS list
PR-URL: nodejs#26383
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Mar 5, 2019

Landed in 713046d, 6e3b216 🎉

@BridgeAR BridgeAR closed this Mar 5, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

tools: add mailmap support for Co-authored-by tags
Support `.mailmap` for manually added `Author:` and
`Co-authored-by:` tags.

PR-URL: nodejs#26383
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

doc: update AUTHORS list
PR-URL: nodejs#26383
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.