-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update AUTHORS list #26383
doc: update AUTHORS list #26383
Conversation
Thang Tran <trankimthang279@gmail.com> | ||
Kai <Schweinepriester@users.noreply.github.com> | ||
Abhishek Agarwal <abhishek.agr31@gmail.com> | ||
Uttam Pawar <upawar@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uttampawar You have committed with two different email addresses – which do you prefer to have listed here?
grimrose <grimrose@users.noreply.github.com> | ||
timothy searcy <timmyzsearcy@gmail.com> | ||
nakashima <nakashima1711@gmail.com> | ||
/Jesse <jesse.katsumata@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is / a redundant here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is taken from the git log, from the Author:
field – @Naturalclar Which name should we use here? Or should we keep the /?
AUTHORS
Outdated
Mikko Rantanen <jubjub@jubjubnest.net> | ||
wenjun ye <1728914873@qq.com> | ||
briete <briete5814@gmail.com> | ||
Matteo Collina <hello@matteocollina.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is @mcollina?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was happening because we didn’t have support for .mailmap
entries for Co-authored-by:
or Author:
tags that were manually added to the commit message.
8f2bb03609c3b4406f80dc4f71d91bdd27ac73f8 should remedy that.
dexterleng <thequicklab@gmail.com> | ||
Kunda Sunil Kumar <kunda.sunilkumar@gmail.com> | ||
rahulshuklab4u <rahulshuklab4u@gmail.com> | ||
gengjiawen <technicalcute@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back then I am young and simple, now I think my email address is silly 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gengjiawen You can always change it for new commits with git config --global user.email foo@bar.com
, and you can always choose one for the AUTHORS
file if you want? :)
(Also, it’s not silly. 🙂)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Maybe later :)
Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags.
David Mark Clements <david.clements@nearform.com> davidmarkclements <huperekchuno@googlemail.com> | ||
David Mark Clements <david.clements@nearform.com> | ||
David Mark Clements <david.clements@nearform.com> <huperekchuno@googlemail.com> | ||
David Mark Clements <david.clements@nearform.com> <david.mark.clements@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidmarkclements Just confirming, since you’ve been freshly listed with a third email address thanks to b1ef279 – the NearForm one is still the one you use for AUTHORS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
@cclauss, this issue log shows that I deleted your comment here: #26383 (comment): I wanted to apologise for that, that comment deletion was not intentional, and I just recently noticed it. I don't remember deleting a comment here (on a purpose or not), it must have been accidental, most likely while I was commenting on this issue from my phone. Unfortunately, I do not have the means of restoring a deleted comment or checking what exactly was in that comment (GitHub does not provide that afaik). The only way that I know how it could be restored is if you re-post it from your side. I really hope that nothing was missed, but in any case — please feel free to restore that comment if you want to. Sorry again 😞 . |
Someone who receives email notifications of comments on this issue might have the content. |
this is what I have in mailbox matching to that day and time - the accidentally deleted comment, for the record: Subject: Re: [nodejs/node] doc: update AUTHORS list (#26383)
From: cclauss
To: nodejs/node, Subscribed
Date: 03/02/2019 07:13 PM
@cclauss commented on this pull request.
In .mailmap:
> @@ -72,6 +73,8 @@ Chew Choon Keat <choonkeat@gmail.com>
Chris Andrews <cpandrews8@gmail.com> cpandrews8 <cpandrews8@gmail.com>
Chris Johnson <chris.s.johnson4@gmail.com>
Chris Young <chris.young@tinder.com> <chris.young@gotinder.com>
+Christian Clauss <cclauss@me.com>
We can keep line 76 and delete line 77. |
Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags. PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags. PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was last updated in September, so I think it’s time. :)