Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused function in cares_wrap.cc #26429

Closed

Conversation

@gengjiawen
Copy link
Member

commented Mar 4, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@cjihrig
cjihrig approved these changes Mar 4, 2019
@BridgeAR

This comment has been minimized.

@jasnell
jasnell approved these changes Mar 5, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
src: remove unused function in cares_wrap.cc
PR-URL: nodejs#26429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

Landed in 51563b2 🎉

@BridgeAR BridgeAR closed this Mar 6, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
src: remove unused function in cares_wrap.cc
PR-URL: nodejs#26429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
src: remove unused function in cares_wrap.cc
PR-URL: #26429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
src: remove unused function in cares_wrap.cc
PR-URL: #26429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.