lib: refactor deprecated function in readline.js #26494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
readline
BridgeAR
reviewed
Mar 7, 2019
gengjiawen
force-pushed
the
rewrite_deprecated_in_readline
branch
from
8fed568
to
e97bac7
Compare
BridgeAR
reviewed
Mar 7, 2019
gengjiawen
force-pushed
the
rewrite_deprecated_in_readline
branch
from
e97bac7
to
1b31834
Compare
gengjiawen
force-pushed
the
rewrite_deprecated_in_readline
branch
from
1b31834
to
b8b146e
Compare
BridgeAR
approved these changes
Mar 8, 2019
BridgeAR
added
the
author ready
|
@BridgeAR I am not quite sure why Jenkins ci failed so many task. Should we re-trigger it ? |
|
@gengjiawen the |
lpinca
approved these changes
Mar 12, 2019
|
Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21476/ ✔️ |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 13, 2019
PR-URL: nodejs#26494 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in b7568e1 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #26494 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 14, 2019
PR-URL: nodejs#26494 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #26494 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes