Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: small improvements #26496

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@gengjiawen
Copy link
Contributor

gengjiawen commented Mar 7, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Show resolved Hide resolved lib/repl.js Outdated

@gengjiawen gengjiawen force-pushed the gengjiawen:regex_improve branch from 40e2d77 to 3ca5b2a Mar 7, 2019

@BridgeAR BridgeAR changed the title small improve for repl repl: small improvements Mar 8, 2019

@BridgeAR

This comment has been minimized.

@targos

targos approved these changes Mar 9, 2019

@gengjiawen gengjiawen referenced this pull request Mar 12, 2019

Closed

src: apply clang-tidy rule modernize-make-unique #26493

1 of 2 tasks complete
@danbev

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Mar 12, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 13, 2019

repl: remove redundant escape
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 13, 2019

repl: simplify regex expression
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 13, 2019

repl: eliminate var in function _memory
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Mar 13, 2019

Landed in b7568e1...024842f 🎉

@BridgeAR BridgeAR closed this Mar 13, 2019

BridgeAR added a commit that referenced this pull request Mar 14, 2019

repl: remove redundant escape
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

repl: simplify regex expression
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

repl: eliminate var in function _memory
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019

repl: remove redundant escape
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019

repl: simplify regex expression
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019

repl: eliminate var in function _memory
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

repl: remove redundant escape
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

repl: simplify regex expression
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

repl: eliminate var in function _memory
PR-URL: #26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

repl: remove redundant escape
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

repl: simplify regex expression
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

repl: eliminate var in function _memory
PR-URL: nodejs#26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.