doc: fix nits in writing-tests.md #26543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct a typo. * Normalize spaces. * Split a paragraph with different topics.
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
addaleax
approved these changes
Mar 9, 2019
lpinca
approved these changes
Mar 9, 2019
vsemozhetbyt
added
fast-track
|
Landed in 4e9dc31 |
vsemozhetbyt
added a commit
that referenced
this pull request
Mar 9, 2019
* Correct a typo. * Normalize spaces. * Split a paragraph with different topics. PR-URL: #26543 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
* Correct a typo. * Normalize spaces. * Split a paragraph with different topics. PR-URL: #26543 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
* Correct a typo. * Normalize spaces. * Split a paragraph with different topics. PR-URL: #26543 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
* Correct a typo. * Normalize spaces. * Split a paragraph with different topics. PR-URL: #26543 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes