Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test case in test-http2-respond-file-304.js #26565

Closed
wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

commented Mar 10, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@BridgeAR
Copy link
Member

left a comment

Good catch

@BridgeAR

This comment has been minimized.

@lpinca
lpinca approved these changes Mar 10, 2019
@BridgeAR BridgeAR referenced this pull request Mar 10, 2019
4 of 4 tasks complete
@richardlau
Copy link
Member

left a comment

Can we lint for cases of assert.strictEqual() with only a single argument?

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Can we lint for cases of assert.strictEqual() with only a single argument?

I think assert.strictEqual() should throw if there is only one argument. The second argument should be required. But that's a semver-major change, I suppose.

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

@richardlau I added such rule in #26569.

@Trott I also thought about doing that while writing the eslint rule. I can add the validation instead - I am just not certain if it's accepted as patch or if someone wants to have it as semver-major change.

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

@BridgeAR I think lint for now and throw later is fine. If we never get around to throwing later, that's OK too.

@danbev

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

Landed in e6fa50e.

@danbev danbev closed this Mar 13, 2019

danbev added a commit that referenced this pull request Mar 13, 2019
test: fix test case in test-http2-respond-file-304.js
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
lib,test: improve faulty assert usage detection
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: nodejs#26569
Refs: nodejs#26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
test: fix test case in test-http2-respond-file-304.js
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
lib,test: improve faulty assert usage detection
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: #26569
Refs: #26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
test: fix test case in test-http2-respond-file-304.js
PR-URL: nodejs#26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
lib,test: improve faulty assert usage detection
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: nodejs#26569
Refs: nodejs#26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
test: fix test case in test-http2-respond-file-304.js
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
lib,test: improve faulty assert usage detection
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: #26569
Refs: #26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019
lib,test: improve faulty assert usage detection
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.

PR-URL: nodejs#26569
Refs: nodejs#26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
test: fix test case in test-http2-respond-file-304.js
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.