Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use EC cert property now that it exists #26598

Closed
wants to merge 1 commit into from
Closed

test: use EC cert property now that it exists #26598

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Remove XXX, there has been an EC specific cert property since
#24358

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@sam-github
test: use EC cert property now that it exists
5fa1d67 
Remove XXX, there has been an EC specific cert property since
nodejs#24358
@nodejs-github-bot
Copy link
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2870/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 11, 2019
@sam-github
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/21447/

@sam-github
Copy link
Contributor Author

Landed in ed2c696

@sam-github sam-github closed this Mar 18, 2019
sam-github added a commit that referenced this pull request Mar 18, 2019
@sam-github
test: use EC cert property now that it exists
ed2c696 
Remove XXX, there has been an EC specific cert property since
#24358

PR-URL: #26598
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@sam-github sam-github deleted the replace-tls-fixme-with-ec-api branch March 20, 2019 15:13
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@sam-github @targos
test: use EC cert property now that it exists
9277235 
Remove XXX, there has been an EC specific cert property since
nodejs#24358

PR-URL: nodejs#26598
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@sam-github @targos
test: use EC cert property now that it exists
9c83002 
Remove XXX, there has been an EC specific cert property since
#24358

PR-URL: #26598
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@watilde watilde watilde approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sam-github @nodejs-github-bot @bnoordhuis @danbev @jasnell @watilde @mihalskiy