Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-worker-prof as flake on all platforms #26600

Merged
merged 1 commit into from
Mar 12, 2019
Merged

test: mark test-worker-prof as flake on all platforms #26600

merged 1 commit into from
Mar 12, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 11, 2019

Refs: #26401

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2872/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 11, 2019
@refack refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 11, 2019
@refack
Copy link
Contributor Author

refack commented Mar 11, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21441/

If this passes, I'd like to fast-track it.
Please 👍 .

@refack
Copy link
Contributor Author

refack commented Mar 11, 2019

/CC @nodejs/testing

@refack
test: mark test-worker-prof as flake on all platforms
e1cd8ac 
PR-URL: nodejs#26600
Refs: nodejs#26401
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@refack refack force-pushed the makr-flake-test-worker-prof branch from 4f837a1 to e1cd8ac Compare March 12, 2019 00:39
@refack refack merged commit e1cd8ac into nodejs:master Mar 12, 2019
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@refack @BridgeAR
test: mark test-worker-prof as flake on all platforms
300ad04 
PR-URL: #26600
Refs: #26401
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@refack @BridgeAR
test: mark test-worker-prof as flake on all platforms
2c55282 
PR-URL: #26600
Refs: #26401
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@refack refack deleted the makr-flake-test-worker-prof branch April 14, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@refack @nodejs-github-bot @Trott @richardlau