Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit "Technical How-To" section of guide #26601

Closed
wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

commented Mar 11, 2019

Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@richardlau

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

section is mispelled in the commit message.

doc: edit "Technical How-To" section of guide
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

@Trott Trott force-pushed the Trott:edit-how-to branch from 77f7adb to 9721185 Mar 12, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

@Trott Trott added the author ready label Mar 12, 2019

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
Update COLLABORATOR_GUIDE.md
Co-Authored-By: Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

@vsemozhetbyt vsemozhetbyt added the meta label Mar 12, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 14, 2019
doc: edit "Technical How-To" section of guide
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: nodejs#26601
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

Landed in 107c95d

@Trott Trott closed this Mar 14, 2019

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019
doc: edit "Technical How-To" section of guide
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: nodejs#26601
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
doc: edit "Technical How-To" section of guide
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: nodejs#26601
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
doc: edit "Technical How-To" section of guide
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: nodejs#26601
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
doc: edit "Technical How-To" section of guide
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: nodejs#26601
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
targos added a commit that referenced this pull request Mar 27, 2019
doc: edit "Technical How-To" section of guide
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: #26601
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@targos targos referenced this pull request Mar 27, 2019
BethGriggs added a commit that referenced this pull request Apr 16, 2019
doc: edit "Technical How-To" section of guide
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: #26601
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.