build: use Xenial and gcc 6 on Travis #26720

richardlau · 2019-03-17T15:00:40Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2019-03-17T15:00:42Z

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2947/pipeline

targos · 2019-03-17T15:18:18Z

I don't think it has to be semver-major. Travis CI results are indicative and we don't rely on them to land PRs.

addaleax

I agree that this isn’t semver-major. You can add dont-land-on labels, if you want, imo.

richardlau · 2019-03-17T15:20:18Z

I don't think it has to be semver-major. Travis CI results are indicative and we don't rely on them to land PRs.

👍 I was being overly cautious (it's easier to downgrade semverness than increase it).

richardlau · 2019-03-17T15:23:46Z

Part of the motivation here was to flush out any unexpectedness on Xenial in Travis CI on the assumption (I've not seen any communication from Travis about this) that Trusty gets sunset when it goes End-of-Life in April and I figured I might as well bump the compiler version based on #26714 while I was here.

richardlau · 2019-03-17T15:27:37Z

The Xenial images on Travis also have gcc-5.4.0 by default. We could potentially speed up the builds on Node.js < 12 by using the default on Xenial and not apt installing another gcc version.

richardlau · 2019-03-19T19:06:11Z

I've restarted the Travis build for this PR a few times but it's always timed out, which is a problem. I don't know yet if it's either a) the Xenial hosts are slow or b) gcc 6 is slow or c) since this is a compiler level change nothing is ccached making the build slow (if this is the case I'm not sure how we fix as it sort of requires a successful build to populate the ccache) or d) some combination of all the above.

My plan is to break up this PR so we test changing one thing at a time (i.e. either the Xenial change on its own or the gcc 6 update on its own) and see if we can work out which one is the problem.

richardlau · 2019-03-19T19:06:51Z

(As an FYI the Travis timeout for jobs is ~50mins.)

targos · 2019-03-19T19:40:24Z

It's probably c) caching issue.

When we push fixes to canary-base, Travis always fails in a timeout. Latest example: https://travis-ci.com/nodejs/node/jobs/186092202

richardlau · 2019-03-19T19:42:57Z

It's probably c) caching issue.

When we push fixes to canary-base, Travis always fails in a timeout. Latest example: https://travis-ci.com/nodejs/node/jobs/186092202

Do the timeouts ever fix themselves? Or is Travis just ignored for canary-base?

targos · 2019-03-19T19:46:31Z

It's probably c) caching issue.
When we push fixes to canary-base, Travis always fails in a timeout. Latest example: https://travis-ci.com/nodejs/node/jobs/186092202

Do the timeouts ever fix themselves? Or is Travis just ignored for canary-base?

I don't think they ever do, because each V8 update usually requires to recompile everything.

richardlau · 2019-03-21T03:53:24Z

I temporarily commented out the script to run tests (so the Travis job just built the binaries) and the build completed in 45 mins: https://travis-ci.com/nodejs/node/jobs/186568593

Uncommented the script and restarted the Travis build to see if it now picks up the ccache and is faster/completes: https://travis-ci.com/nodejs/node/jobs/186560878

richardlau · 2019-03-21T04:07:57Z

Build completed in 14mins once the ccache was created (by a previous build that didn't run tests to avoid the timeout). We may need to do a similar trick when landing this.

We're hitting the Travis job timeout of 50mins if built with a new compiler (as there is no ccache). Temporarily disable the running of tests so the Travis job can complete within the timeout and populate the ccache.

Restore running tests on Travis once the ccache is populated.

Restore running tests on Travis once the ccache is populated. PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

richardlau · 2019-03-22T04:04:42Z

https://travis-ci.com/nodejs/node/jobs/186890380 succeeded (:tada:) so we should now have a ccache.

Landed db40b4a. Travis: https://travis-ci.com/nodejs/node/jobs/186898338

richardlau · 2019-03-22T04:31:44Z

We're all good now. Let's hope nothing happens to the ccache 🤞.

Landed in ecf98b0...db40b4a.

PR-URL: nodejs#26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

We're hitting the Travis job timeout of 50mins if built with a new compiler (as there is no ccache). Temporarily disable the running of tests so the Travis job can complete within the timeout and populate the ccache. PR-URL: nodejs#26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Restore running tests on Travis once the ccache is populated. PR-URL: nodejs#26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

We're hitting the Travis job timeout of 50mins if built with a new compiler (as there is no ccache). Temporarily disable the running of tests so the Travis job can complete within the timeout and populate the ccache. PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Restore running tests on Travis once the ccache is populated. PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

We're hitting the Travis job timeout of 50mins if built with a new compiler (as there is no ccache). Temporarily disable the running of tests so the Travis job can complete within the timeout and populate the ccache. PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Restore running tests on Travis once the ccache is populated. PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

We're hitting the Travis job timeout of 50mins if built with a new compiler (as there is no ccache). Temporarily disable the running of tests so the Travis job can complete within the timeout and populate the ccache. PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Restore running tests on Travis once the ccache is populated. PR-URL: #26720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

richardlau added wip Issues and PRs that are still a work in progress. semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 17, 2019

addaleax removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 17, 2019

addaleax approved these changes Mar 17, 2019

View reviewed changes

richardlau added build Issues and PRs related to build files or the CI. and removed wip Issues and PRs that are still a work in progress. labels Mar 17, 2019

richardlau changed the title ~~WIP build: use Xenial and gcc 6 on Travis~~ build: use Xenial and gcc 6 on Travis Mar 17, 2019

lpinca approved these changes Mar 17, 2019

View reviewed changes

targos approved these changes Mar 17, 2019

View reviewed changes

gengjiawen approved these changes Mar 17, 2019

View reviewed changes

refack approved these changes Mar 18, 2019

View reviewed changes

richardlau added the wip Issues and PRs that are still a work in progress. label Mar 19, 2019

richardlau force-pushed the travis12 branch 2 times, most recently from bb4c0e7 to d9bbf0c Compare March 21, 2019 03:49

richardlau removed the wip Issues and PRs that are still a work in progress. label Mar 21, 2019

richardlau added 3 commits March 21, 2019 20:33

build: use Xenial and gcc 6 on Travis

0d6dfef

build: temporarily don't run tests on Travis

2bbf24d

We're hitting the Travis job timeout of 50mins if built with a new compiler (as there is no ccache). Temporarily disable the running of tests so the Travis job can complete within the timeout and populate the ccache.

build: restore running tests on Travis

ed8b067

Restore running tests on Travis once the ccache is populated.

richardlau closed this Mar 22, 2019

targos mentioned this pull request Mar 27, 2019

v11.13.0 release proposal #26949

Merged

richardlau mentioned this pull request Mar 28, 2019

build,meta: tweak Travis config #26969

Merged

4 tasks

BethGriggs mentioned this pull request May 1, 2019

v10.16.0 proposal #27514

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: use Xenial and gcc 6 on Travis #26720

build: use Xenial and gcc 6 on Travis #26720

richardlau commented Mar 17, 2019 •

edited

Loading

nodejs-github-bot commented Mar 17, 2019

targos commented Mar 17, 2019

addaleax left a comment

richardlau commented Mar 17, 2019

richardlau commented Mar 17, 2019

richardlau commented Mar 17, 2019 •

edited

Loading

richardlau commented Mar 19, 2019 •

edited

Loading

richardlau commented Mar 19, 2019

targos commented Mar 19, 2019

richardlau commented Mar 19, 2019

targos commented Mar 19, 2019 •

edited

Loading

richardlau commented Mar 21, 2019

richardlau commented Mar 21, 2019

richardlau commented Mar 22, 2019

richardlau commented Mar 22, 2019

build: use Xenial and gcc 6 on Travis #26720

build: use Xenial and gcc 6 on Travis #26720

Conversation

richardlau commented Mar 17, 2019 • edited Loading

Checklist

nodejs-github-bot commented Mar 17, 2019

targos commented Mar 17, 2019

addaleax left a comment

Choose a reason for hiding this comment

richardlau commented Mar 17, 2019

richardlau commented Mar 17, 2019

richardlau commented Mar 17, 2019 • edited Loading

richardlau commented Mar 19, 2019 • edited Loading

richardlau commented Mar 19, 2019

targos commented Mar 19, 2019

richardlau commented Mar 19, 2019

targos commented Mar 19, 2019 • edited Loading

richardlau commented Mar 21, 2019

richardlau commented Mar 21, 2019

richardlau commented Mar 22, 2019

richardlau commented Mar 22, 2019

richardlau commented Mar 17, 2019 •

edited

Loading

richardlau commented Mar 17, 2019 •

edited

Loading

richardlau commented Mar 19, 2019 •

edited

Loading

targos commented Mar 19, 2019 •

edited

Loading