Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,win: fix usage of deprecated v8::Object::Set #26735

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
5 participants
@targos
Copy link
Member

commented Mar 18, 2019

Refs: #26733

@targos

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

@refack

@refack

refack approved these changes Mar 18, 2019

@targos

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

@targos targos added the author ready label Mar 18, 2019

@refack refack added the fast-track label Mar 18, 2019

@refack

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

This is pure win, so I move for fast-tacking. Please 👍 this comment if you concur.

src,win: fix usage of deprecated v8::Object::Set
PR-URL: #26735
Refs: #26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@refack refack force-pushed the targos:dep-win branch from f5c3aaf to 6e678b1 Mar 18, 2019

@refack refack removed the author ready label Mar 18, 2019

@refack refack merged commit 6e678b1 into nodejs:master Mar 18, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@targos targos deleted the targos:dep-win branch Mar 18, 2019

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

src,win: fix usage of deprecated v8::Object::Set
PR-URL: nodejs#26735
Refs: nodejs#26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

src,win: fix usage of deprecated v8::Object::Set
PR-URL: nodejs#26735
Refs: nodejs#26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

src,win: fix usage of deprecated v8::Object::Set
PR-URL: nodejs#26735
Refs: nodejs#26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

src,win: fix usage of deprecated v8::Object::Set
PR-URL: nodejs#26735
Refs: nodejs#26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

targos added a commit that referenced this pull request Mar 27, 2019

src,win: fix usage of deprecated v8::Object::Set
PR-URL: #26735
Refs: #26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.