Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: reduced internal usage of public require('util') #26875

Closed
wants to merge 1 commit into from
Closed

lib: reduced internal usage of public require('util') #26875

wants to merge 1 commit into from

Conversation

DavidLi119
Copy link

@DavidLi119 DavidLi119 commented Mar 23, 2019 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@DavidLi119
Copy link
Author

unable to perform vcbuild test as I have install python but Visual Studios Code cannot find python 2.x

ZYSzys
ZYSzys reviewed Mar 23, 2019
View reviewed changes
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution first.

But sorry for this, it was duplicated with #26833

@DavidLi119
Copy link
Author

Understood, I will close this pull request

@DavidLi119 DavidLi119 closed this Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavidLi119 @ZYSzys