Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: `inspect()` should not exceed `breakLength` #26914

Closed

Conversation

@BridgeAR
Copy link
Member

commented Mar 26, 2019

Using util.inspect() with the compact option set to a number
could result in output that exceeded the breakLength option. This
change makes sure that limit is taken into account.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
util: `inspect()` should not exceed `breakLength`
Using `util.inspect()` with the `compact` option set to a number
could result in output that exceeded the `breakLength` option. This
change makes sure that limit is taken into account.
@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

@BridgeAR BridgeAR requested a review from addaleax Mar 27, 2019

@BridgeAR BridgeAR removed the assert label Mar 27, 2019

@targos
targos approved these changes Mar 29, 2019
@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2019

@BridgeAR BridgeAR requested review from antsmartian, mcollina and jasnell Mar 30, 2019

@mcollina
Copy link
Member

left a comment

LGTM

@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

Landed in e1e9f1e.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 3, 2019
util: `inspect()` should not exceed `breakLength`
Using `util.inspect()` with the `compact` option set to a number
could result in output that exceeded the `breakLength` option. This
change makes sure that limit is taken into account.

PR-URL: nodejs#26914
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

@BridgeAR BridgeAR closed this Apr 3, 2019

BethGriggs added a commit that referenced this pull request Apr 5, 2019
util: `inspect()` should not exceed `breakLength`
Using `util.inspect()` with the `compact` option set to a number
could result in output that exceeded the `breakLength` option. This
change makes sure that limit is taken into account.

PR-URL: #26914
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
util: `inspect()` should not exceed `breakLength`
Using `util.inspect()` with the `compact` option set to a number
could result in output that exceeded the `breakLength` option. This
change makes sure that limit is taken into account.

PR-URL: #26914
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
util: `inspect()` should not exceed `breakLength`
Using `util.inspect()` with the `compact` option set to a number
could result in output that exceeded the `breakLength` option. This
change makes sure that limit is taken into account.

PR-URL: #26914
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs referenced this pull request Apr 9, 2019
BethGriggs added a commit that referenced this pull request Apr 10, 2019
util: `inspect()` should not exceed `breakLength`
Using `util.inspect()` with the `compact` option set to a number
could result in output that exceeded the `breakLength` option. This
change makes sure that limit is taken into account.

PR-URL: #26914
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.