Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix error code typo #27024

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
10 participants
@cjihrig
Copy link
Contributor

commented Mar 31, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2019

Looks like this is not just a typo fix. Pushed up other fixes.

@Trott

Trott approved these changes Mar 31, 2019

Copy link
Member

left a comment

Thanks for fixing my multiple mistakes with this.

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

Seems like a candidate for fast-tracking? 👍 if you're a Collaborator and agree.

@Trott Trott added the fast-track label Mar 31, 2019

@ZYSzys

ZYSzys approved these changes Mar 31, 2019

@targos

targos approved these changes Mar 31, 2019

@cjihrig cjihrig force-pushed the cjihrig:typo branch from dbe07ef to 95c9204 Mar 31, 2019

@nodejs-github-bot

This comment has been minimized.

@lpinca

lpinca approved these changes Mar 31, 2019

@nodejs-github-bot

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Landed in e573394.

@danbev danbev closed this Apr 1, 2019

danbev added a commit that referenced this pull request Apr 1, 2019

test: fix error code typo
PR-URL: #27024
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@cjihrig cjihrig deleted the cjihrig:typo branch Apr 1, 2019

BethGriggs added a commit that referenced this pull request Apr 5, 2019

test: fix error code typo
PR-URL: #27024
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BethGriggs added a commit that referenced this pull request Apr 9, 2019

test: fix error code typo
PR-URL: #27024
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request Apr 9, 2019

test: fix error code typo
PR-URL: #27024
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

@BethGriggs BethGriggs referenced this pull request Apr 9, 2019

Merged

v11.14.0 proposal #27163

MylesBorins added a commit to MylesBorins/node that referenced this pull request May 20, 2019

test: fix error code typo
PR-URL: nodejs#27024
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request May 21, 2019

test: fix error code typo
Backport-PR-URL: #27776
PR-URL: #27024
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@BethGriggs BethGriggs referenced this pull request May 22, 2019

Merged

v10.16.0 proposal #27514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.