Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] deps: V8: backport d520ebb #27358

Closed
wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

targos commented Apr 23, 2019

Original commit message:

[turbofan] Fix NumberFloor typing.

Bug: chromium:841117
Change-Id: I1e83dfc82f87d0b49d3cca96290ae1d738e37d20
Reviewed-on: https://chromium-review.googlesource.com/1051228
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53083}

Refs: v8/v8@d520ebb
Fixes: #22810

Original commit message:

    [turbofan] Fix NumberFloor typing.

    Bug: chromium:841117
    Change-Id: I1e83dfc82f87d0b49d3cca96290ae1d738e37d20
    Reviewed-on: https://chromium-review.googlesource.com/1051228
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53083}

Refs: v8/v8@d520ebb
Fixes: #22810
@nodejs-github-bot

This comment has been minimized.

@targos targos changed the title deps: V8: backport d520ebb [v8.x] deps: V8: backport d520ebb Apr 23, 2019
@targos

This comment has been minimized.

Copy link
Member Author

targos commented Apr 23, 2019

@nodejs-github-bot

This comment was marked as outdated.

@refack
refack approved these changes Apr 23, 2019
@nodejs-github-bot

This comment has been minimized.

@sam-github sam-github closed this Jun 5, 2019
@targos

This comment has been minimized.

Copy link
Member Author

targos commented Jun 5, 2019

@sam-github why did you close this?

@BridgeAR BridgeAR reopened this Jun 5, 2019
@sam-github

This comment has been minimized.

Copy link
Member

sam-github commented Jun 6, 2019

@targos I closed it by mistake, sorry!

@targos

This comment has been minimized.

Copy link
Member Author

targos commented Jun 11, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Sep 19, 2019

BethGriggs added a commit that referenced this pull request Sep 19, 2019
Original commit message:

    [turbofan] Fix NumberFloor typing.

    Bug: chromium:841117
    Change-Id: I1e83dfc82f87d0b49d3cca96290ae1d738e37d20
    Reviewed-on: https://chromium-review.googlesource.com/1051228
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53083}

Refs: v8/v8@d520ebb
Fixes: #22810

PR-URL: #27358
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs

This comment has been minimized.

Copy link
Member

BethGriggs commented Sep 19, 2019

Landed on v8.x-staging

@BethGriggs BethGriggs closed this Sep 19, 2019
@targos targos deleted the targos:fix-22810 branch Sep 19, 2019
@BethGriggs BethGriggs referenced this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.