Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: backport ICU-20575 to fix err/crasher #27435

Closed
wants to merge 2 commits into from

Conversation

@srl295
Copy link
Member

commented Apr 26, 2019

  • Floating patch for ICU 64.x

(does not apply to 63.x)

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included: TODO!!
  • commit message follows commit guidelines

@srl295 srl295 added the intl label Apr 26, 2019

@srl295 srl295 self-assigned this Apr 26, 2019

@nodejs-github-bot

This comment has been minimized.

deps: backport ICU-20575 to fix err/crasher
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

@srl295 srl295 force-pushed the srl295:patch-ICU-20575 branch from eec98a0 to 2566e66 Apr 26, 2019

@srl295 srl295 marked this pull request as ready for review Apr 26, 2019

@srl295 srl295 requested review from targos, refack and ryzokuken Apr 26, 2019

@nodejs-github-bot

This comment has been minimized.

@srl295

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

to quote @refack in #27415 . do we want to fasttrack this one also? it's a similar crash and may be causing the other issue to be exposed.

Please 👍 if you concur.

@refack
refack approved these changes Apr 27, 2019

@refack refack added the fast-track label Apr 27, 2019

@nodejs-github-bot

This comment has been minimized.

@targos
targos approved these changes Apr 27, 2019
@targos

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Landed in 31ac8b9

@targos targos closed this Apr 27, 2019

targos added a commit that referenced this pull request Apr 27, 2019
deps: backport ICU-20575 to fix err/crasher
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

PR-URL: #27435
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos added a commit that referenced this pull request Apr 27, 2019
deps: backport ICU-20575 to fix err/crasher
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

PR-URL: #27435
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Apr 27, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
deps: backport ICU-20575 to fix err/crasher
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

PR-URL: #27435
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs added a commit that referenced this pull request May 10, 2019
deps: backport ICU-20575 to fix err/crasher
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

PR-URL: #27435
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
deps: backport ICU-20575 to fix err/crasher
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

PR-URL: #27435
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.