Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: doc deprecate the legacy http parser #27498

Merged
merged 1 commit into from May 9, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Apr 30, 2019

This PR begins the process of deprecating the legacy http parser.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Show resolved Hide resolved doc/api/deprecations.md Outdated
@Trott

Trott approved these changes Apr 30, 2019

@cjihrig cjihrig force-pushed the cjihrig:parser-depr branch from 457f176 to 682cbcc Apr 30, 2019

@addaleax
Copy link
Member

left a comment

LGTM – If you want, feel free to point out that we may not stick to a proper deprecation cycle here, since this is not (supposed to be) an API change.

@BridgeAR
Copy link
Member

left a comment

LGTM. It just needs a rebase.

@lpinca

lpinca approved these changes May 7, 2019

@shisama

shisama approved these changes May 8, 2019

@trivikr

trivikr approved these changes May 9, 2019

@cjihrig cjihrig force-pushed the cjihrig:parser-depr branch from 682cbcc to 60dba9c May 9, 2019

cjihrig added a commit to cjihrig/node-1 that referenced this pull request May 9, 2019

doc: doc deprecate the legacy http parser
PR-URL: nodejs#27498
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
doc: doc deprecate the legacy http parser
PR-URL: #27498
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:parser-depr branch from 60dba9c to 6259c52 May 9, 2019

@cjihrig cjihrig merged commit 6259c52 into nodejs:master May 9, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:parser-depr branch May 9, 2019

targos added a commit that referenced this pull request May 10, 2019

doc: doc deprecate the legacy http parser
PR-URL: #27498
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@BridgeAR BridgeAR referenced this pull request May 21, 2019

Open

v12.3.0 proposal #27799

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.