src: remove freebsd SA_RESETHAND workaround #27780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround should no longer be necessary with supported versions of FreeSBD. Originall introduced in commit b64983d ("src: reset signal handler to SIG_DFL on FreeBSD") from March 2015. Fixes: nodejs#27515 Refs: nodejs#27246 (comment)
nodejs-github-bot
added
the
c++
4 tasks
cjihrig
approved these changes
May 20, 2019
targos
approved these changes
May 20, 2019
Trott
approved these changes
May 20, 2019
addaleax
approved these changes
May 21, 2019
|
Is |
pull bot
pushed a commit
to shakir-abdo/node
that referenced
this pull request
May 23, 2019
This workaround should no longer be necessary with supported versions of FreeSBD. Originally introduced in commit b64983d ("src: reset signal handler to SIG_DFL on FreeBSD") from March 2015. Fixes: nodejs#27515 PR-URL: nodejs#27780 Refs: nodejs#27246 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
@targos You can feel free to remove it if you feel comfortable doing so. It’s not necessary, not breaking stuff unless we have to was just my personal preference here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround should no longer be necessary with supported versions
of FreeSBD.
Originall introduced in commit b64983d ("src: reset signal handler to
SIG_DFL on FreeBSD") from March 2015.
Fixes: #27515
Refs: #27246 (comment)
CI: https://ci.nodejs.org/job/node-test-pull-request/23227/