Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 7.6 #28016

Closed
wants to merge 20 commits into from

Conversation

@ryzokuken
Copy link
Member

commented Jun 2, 2019

馃帀
Thanks @targos @refack

@cjihrig could you PTAL at 9106789?

@ryzokuken ryzokuken requested review from refack and targos Jun 2, 2019

@ryzokuken

This comment has been minimized.

Copy link
Member Author

commented Jun 2, 2019

@nodejs-github-bot

This comment was marked as outdated.

@targos

This comment was marked as resolved.

Copy link
Member

commented Jun 2, 2019

a05408b and d1e3650 are empty commits (just incrementing the embedder string) and can be removed

@targos

This comment was marked as resolved.

Copy link
Member

commented Jun 2, 2019

There's an unhandled conflict here: 5a9af9b

@targos

This comment was marked as resolved.

Copy link
Member

commented Jun 2, 2019

There are some unhandled conflicts here: bea6519

@targos

This comment was marked as resolved.

@targos targos force-pushed the ryzokuken:v8-7.6 branch 2 times, most recently from 28704ed to fe8bf54 Jun 2, 2019

@targos

This comment was marked as resolved.

Copy link
Member

commented Jun 2, 2019

@refack

13:34:47 PYTHONPATH=tools/pip python2 -m flake8 --count --show-source --statistics .
13:34:53 ./tools/v8_gypfiles/GN-scraper.py:23:46: F812 list comprehension redefines 'f' from line 10
13:34:53   rel_files = ['"%s/%s"' % (src_root, f) for f in files]
13:34:53                                              ^
13:34:53 1     F812 list comprehension redefines 'f' from line 10
13:34:53 1
13:34:53 gmake: *** [Makefile:1329: lint-py] Error 1
@targos

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

@cjihrig Along with 9106789 (which I had to do to make it compile), we have some missing constants: v8dbg_class_FixedTypedArrayBase__base_pointer__Object,v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t,v8dbg_class_Map__instance_descriptors_offset

@refack

This comment was marked as resolved.

Copy link
Member

commented Jun 2, 2019

F812 list comprehension redefines 'f' from line 10

We just need to rename the f... on it way.

@miladfarca

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

s390 and ppc are segfaulting on some tests because of this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1632235, we have a solution but waiting on the original owner to get back to us on a question first.

@nodejs-github-bot

This comment was marked as outdated.

@targos

This comment was marked as resolved.

Copy link
Member

commented Jun 2, 2019

馃槺 what happened to aix??

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

@cjihrig could you PTAL at 9106789?

Sure thing.

@refack

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

馃槺 what happened to aix??

It get's that way from time to time.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs nodejs deleted a comment from nodejs-github-bot Jun 2, 2019

@refack

This comment was marked as resolved.

Copy link
Member

commented Jun 2, 2019

馃槺 what happened to aix??

It get's that way from time to time.

What happened to the perma-yellow PPC (from test-worker-prof)? It seems to be green.

@miladfarca

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

@refack the flaky test? might be an undefined behaviour where it passes or fails form time to time (due to this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1561072), will be looking into it using V8 master.

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@ryzokuken / @targos can you try cherry-picking in cjihrig@19d7b31 and cjihrig@9e50c0a.

@ryzokuken ryzokuken force-pushed the ryzokuken:v8-7.6 branch from 8e8a2c3 to ed3e45d Jun 3, 2019

@ryzokuken

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

@cjihrig @targos @refack fixed and done! PTAL. Making this PR ready for review. 馃帀

@ryzokuken ryzokuken marked this pull request as ready for review Jun 3, 2019

nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 14, 2019
deps: V8: fix filename manipulation for Windows
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 14, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 14, 2019
deps: V8: fix linking issue for MSVS
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 15, 2019
deps: V8: fix filename manipulation for Windows
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 15, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 15, 2019
deps: V8: fix linking issue for MSVS
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 16, 2019
deps: V8: fix filename manipulation for Windows
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 16, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 16, 2019
deps: V8: fix linking issue for MSVS
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 17, 2019
deps: V8: fix filename manipulation for Windows
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 17, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 17, 2019
deps: V8: fix linking issue for MSVS
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit to targos/node that referenced this pull request Sep 17, 2019
deps: V8: fix filename manipulation for Windows
PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit to targos/node that referenced this pull request Sep 17, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit to targos/node that referenced this pull request Sep 17, 2019
deps: V8: fix linking issue for MSVS
PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
deps: V8: fix filename manipulation for Windows
Backport-PR-URL: #29241
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

Backport-PR-URL: #29241
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
deps: V8: fix linking issue for MSVS
Backport-PR-URL: #29241
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit that referenced this pull request Sep 20, 2019
deps: V8: fix filename manipulation for Windows
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit that referenced this pull request Sep 20, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos added a commit that referenced this pull request Sep 20, 2019
deps: V8: fix linking issue for MSVS
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 20, 2019
deps: V8: fix filename manipulation for Windows
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 20, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 20, 2019
deps: V8: fix linking issue for MSVS
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 21, 2019
deps: V8: fix filename manipulation for Windows
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 21, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 21, 2019
deps: V8: fix linking issue for MSVS
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 22, 2019
deps: V8: fix filename manipulation for Windows
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 22, 2019
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-ci added a commit to nodejs/node-v8 that referenced this pull request Sep 22, 2019
deps: V8: fix linking issue for MSVS
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (专驻讗诇 驻诇讞讬) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.