Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a n-api external test #28295

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Himself65
Copy link
Contributor

commented Jun 19, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Himself65 Himself65 force-pushed the Himself65:external branch 3 times, most recently from 761ab7f to ff357ac Jun 19, 2019

@Himself65 Himself65 force-pushed the Himself65:external branch from ff357ac to 658507b Jun 20, 2019

@ZYSzys ZYSzys added the n-api label Jun 20, 2019

@mhdawson

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

There is some testing of externals in js-native-api/test_reference.

Could you take a look and just add a short note on how this testing covers different aspects of Externals?

@Himself65 Himself65 closed this Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.