Test fix description #28351
Closed
Test fix description #28351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This description was fixed. Test are working fine, but the description was not correct
This description was fixed. Test are working fine, but the description was not correct
Trott
approved these changes
Jun 21, 2019
ZYSzys
approved these changes
Jun 22, 2019
addaleax
approved these changes
Jun 22, 2019
BridgeAR
approved these changes
Jun 22, 2019
trivikr
approved these changes
Jun 23, 2019
jasnell
added
the
code-and-learn
jasnell
approved these changes
Jun 23, 2019
addaleax
added
the
author ready
This comment has been minimized.
This comment has been minimized.
gengjiawen
approved these changes
Jul 2, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in 3d56e89. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2019
test-buffer-failed-alloc-typed-arrays.js is working fine, but the description was not correct. PR-URL: nodejs#28351 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
test-buffer-failed-alloc-typed-arrays.js is working fine, but the description was not correct. PR-URL: #28351 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This description was fixed. Test are working fine, but the description was not correct
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes