Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clang build warning fix #28480

Closed
wants to merge 1 commit into from
Closed

src: clang build warning fix #28480

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

fix UB with string concatenations. += operator makes things
clearer for compiler's perspective.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 30, 2019
@devnexen devnexen changed the title src: clang build warning fix. src: clang build warning fix Jun 30, 2019
addaleax
addaleax approved these changes Jul 1, 2019
View reviewed changes
src/node_metadata.cc Outdated Show resolved Hide resolved
@devnexen
src: clang build warning fix
98b8b0b 
fix UB with string concatenations. += operator makes things
clearer for compiler's perspective.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24262/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2019
@Trott
Copy link
Member

Trott commented Jul 12, 2019

Landed in fe1b96d

@Trott Trott closed this Jul 12, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 12, 2019
@devnexen @Trott
src: clang build warning fix
fe1b96d 
fix UB with string concatenations. += operator makes things
clearer for compiler's perspective.

PR-URL: nodejs#28480
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2019
@devnexen @targos
src: clang build warning fix
22daf95 
fix UB with string concatenations. += operator makes things
clearer for compiler's perspective.

PR-URL: #28480
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devnexen @nodejs-github-bot @Trott @addaleax