src: large pages fix FreeBSD fix region size #28735
Conversation
nodejs-github-bot
added
the
c++
devnexen
changed the title
|
Is this @nodejs/platform-freebsd specific? I labelled it as such, based on the commit message, please comment if that was incorrect. The commit message/PR could use some more description. It appears you have switched the size calculation from being before the alignment of the start/end, to after. Does this have an effect which can be tested? |
|
@sam-github it definitely is :-) It has an effect only of the number of large pages now it is correct since it comes from the aligned lower and upper boundary of the address. |
Makes the size aligned to huge page size by calculating it from the aligned lower and upper boundary of the executable address.
|
commit message looks good, hopefully someone on @nodejs/platform-freebsd can confirm its correct. Is there a way to do a before and after test, even if its manual, to see what went wrong before, and what is working now? |
|
In fact I was just curious to print the number of size and total huge page and realised where the issue came from, since we divide by the size of huge page that quite "jump to the face". I got few thumb ups I guess I m not far from the truth :-) |
|
This needs a review. /ping @nodejs/build @nodejs/collaborators |
|
Landed in de88d6c |
Makes the size aligned to huge page size by calculating it from the aligned lower and upper boundary of the executable address. PR-URL: nodejs#28735 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Makes the size aligned to huge page size by calculating it from the aligned lower and upper boundary of the executable address. PR-URL: #28735 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Makes the size aligned to huge page size by calculating it from the aligned lower and upper boundary of the executable address. PR-URL: nodejs#28735 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Makes the size aligned to huge page size.