stream: readable error emitted #29009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
|
Still need to consider what/how to test here. |
7 tasks
ronag
force-pushed
the
stream-readable-error-emitted
branch
from
f86dba6
to
43093f5
Compare
mcollina
reviewed
Aug 7, 2019
lib/_stream_writable.js
Outdated
| @@ -428,13 +428,11 @@ function onwriteError(stream, state, sync, er, cb) { | |||
| // This can emit finish, and it will always happen | |||
| // after error | |||
| process.nextTick(finishMaybe, stream, state); | |||
| stream._writableState.errorEmitted = true; | |||
There was a problem hiding this comment.
As said in one of other PRs, these should be kept.
There was a problem hiding this comment.
This change should not be here at all. Error from my side.
mcollina
added
the
semver-major
|
Can you please avoid piling up commits from other PRs? Either open a "big" PR with multiple commits, or wait before the previous has landed. Also, this needs a unit test. |
mcollina
requested changes
Aug 7, 2019
ronag
force-pushed
the
stream-readable-error-emitted
branch
from
43093f5
to
bb2a821
Compare
|
replaced by #29058 |
This was referenced Jan 19, 2021
This was referenced Sep 5, 2021
This was referenced Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track whether error has been emitted on readable as well. This will allow some minor refactoring and optimisations on stream helpers.
Depends/Based on: #28709.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes