Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: fix file close error condition at respondWithFd #29884

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

addaleax commented Oct 8, 2019

Closing a FileHandle almost never fails, so it was hard to
notice before that stream.emit(err) would not emit an error
event due to the missing event name.

Destroying the stream with the error seems like the right thing
to do in that scenario.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Closing a FileHandle almost never fails, so it was hard to
notice before that `stream.emit(err)` would not emit an error
event due to the missing event name.

Destroying the stream with the error seems like the right thing
to do in that scenario.
@cjihrig
cjihrig approved these changes Oct 8, 2019
@nodejs-github-bot

This comment has been minimized.

@ZYSzys
ZYSzys approved these changes Oct 8, 2019
@lpinca
lpinca approved these changes Oct 8, 2019
@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Oct 8, 2019

I guess there is no way to add a unit test, right?

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Oct 8, 2019

I’ve tried but couldn’t come up with a good way, no.

@ronag
ronag approved these changes Oct 9, 2019
@jasnell
jasnell approved these changes Oct 9, 2019
@devsnek
devsnek approved these changes Oct 9, 2019
Copy link
Member

devsnek left a comment

we could create a fuse mount that refuses to close files :P

@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the author ready label Oct 11, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 11, 2019

Landed in 624fa41

@Trott Trott closed this Oct 11, 2019
Trott added a commit that referenced this pull request Oct 11, 2019
Closing a FileHandle almost never fails, so it was hard to
notice before that `stream.emit(err)` would not emit an error
event due to the missing event name.

Destroying the stream with the error seems like the right thing
to do in that scenario.

PR-URL: #29884
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos added a commit that referenced this pull request Nov 8, 2019
Closing a FileHandle almost never fails, so it was hard to
notice before that `stream.emit(err)` would not emit an error
event due to the missing event name.

Destroying the stream with the error seems like the right thing
to do in that scenario.

PR-URL: #29884
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos added a commit that referenced this pull request Nov 10, 2019
Closing a FileHandle almost never fails, so it was hard to
notice before that `stream.emit(err)` would not emit an error
event due to the missing event name.

Destroying the stream with the error seems like the right thing
to do in that scenario.

PR-URL: #29884
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.