Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: buffer dir entries in opendir() #29893

Closed
wants to merge 6 commits into from

Commits on Oct 10, 2019

  1. fs: buffer dir entries in opendir()

    Read up to 32 directory entries in one batch when `dir.readSync()`
    or `dir.read()` are called.
    
    This increases performance significantly, although it introduces
    quite a bit of edge case complexity.
    
                                                                     confidence improvement accuracy (*)    (**)    (***)
         fs/bench-opendir.js mode='async' dir='lib' n=100                  ***    155.93 %      ±30.05% ±40.34%  ±53.21%
         fs/bench-opendir.js mode='async' dir='test/parallel' n=100        ***    479.65 %      ±56.81% ±76.47% ±101.32%
         fs/bench-opendir.js mode='sync' dir='lib' n=100                           10.38 %      ±14.39% ±19.16%  ±24.96%
         fs/bench-opendir.js mode='sync' dir='test/parallel' n=100         ***     63.13 %      ±12.84% ±17.18%  ±22.58%
    addaleax committed Oct 10, 2019
    Copy the full SHA
    8bf527e View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    6d209fc View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    c66840d View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    e2f1071 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    59cf84d View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. Copy the full SHA
    751a8b6 View commit details
    Browse the repository at this point in the history