Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix version checks in gyp files #29931

Closed
wants to merge 1 commit into from
Closed

build: fix version checks in gyp files #29931

wants to merge 1 commit into from

Commits on Oct 11, 2019

  1. build: fix version checks in gyp files 

    Make `distutils.version.StrictVersion` available as a helper to
gyp expressions so they can do proper version checks and update
the gyp files accordingly.

Caveat emptor: `StrictVersion` does *not* like empty strings so
this commit adds truthiness guards. The helper could deal with
those but I felt it better to make it explicit.

Fixes: nodejs#29927
    @bnoordhuis
    bnoordhuis committed Oct 11, 2019
    Copy the full SHA
    e666202 View commit details
    Browse the repository at this point in the history