Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: npm: patch support for 13.x #30079

Closed
wants to merge 1 commit into from

Conversation

@MylesBorins
Copy link
Member

MylesBorins commented Oct 23, 2019

This should keep the npm warning at bay until it is patched
upstream.

/cc @ljharb

Refs: npm/cli#269
Refs: #30066

@MylesBorins

This comment has been minimized.

Copy link
Member Author

MylesBorins commented Oct 23, 2019

Can we please fast track this? I can help prepare a v13.1.0 release asap to get the fix out.

@MylesBorins MylesBorins changed the title deps: npm: patch support for 13.0.0 deps: npm: patch support for 13.x Oct 23, 2019
This should keep the npm warning at bay until it is patched
upstream.

Refs: npm/cli#269
Refs: #30066
@MylesBorins MylesBorins force-pushed the MylesBorins:fix-npm-13 branch from c121cfd to f8a689f Oct 23, 2019
@nodejs-github-bot

This comment has been minimized.

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Oct 23, 2019

@MylesBorins v13.0.1 i hope

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Oct 23, 2019

(LGTM)

@targos
targos approved these changes Oct 23, 2019
@addaleax addaleax added the fast-track label Oct 23, 2019
@MylesBorins

This comment has been minimized.

Copy link
Member Author

MylesBorins commented Oct 23, 2019

landed in d8aa38c

MylesBorins added a commit that referenced this pull request Oct 23, 2019
This should keep the npm warning at bay until it is patched
upstream.

Refs: npm/cli#269
Refs: #30066

PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins deleted the MylesBorins:fix-npm-13 branch Oct 23, 2019
MylesBorins added a commit that referenced this pull request Oct 23, 2019
This should keep the npm warning at bay until it is patched
upstream.

Refs: npm/cli#269
Refs: #30066

PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins referenced this pull request Oct 23, 2019
@MylesBorins

This comment has been minimized.

Copy link
Member Author

MylesBorins commented Oct 23, 2019

PR for 13.0.1 opened #30081

targos added a commit that referenced this pull request Oct 23, 2019
Notable changes:

* deps:
  * Fixed a bug in npm 6.12.0 where warnings are emitted on Node.js
    13.x. #30079
* esm:
  * Changed file extension resolution order of
    `--es-module-specifier-resolution=node`to match that of the CommonJS
    loader. #29974

PR-URL: #30081
targos added a commit that referenced this pull request Oct 23, 2019
Notable changes:

* deps:
  * Fixed a bug in npm 6.12.0 where warnings are emitted on Node.js
    13.x. #30079
* esm:
  * Changed file extension resolution order of
    `--es-module-specifier-resolution=node`to match that of the CommonJS
    loader. #29974

PR-URL: #30081
targos added a commit that referenced this pull request Nov 8, 2019
This should keep the npm warning at bay until it is patched
upstream.

Refs: npm/cli#269
Refs: #30066

PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Nov 10, 2019
This should keep the npm warning at bay until it is patched
upstream.

Refs: npm/cli#269
Refs: #30066

PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Nov 11, 2019
This should keep the npm warning at bay until it is patched
upstream.

Refs: npm/cli#269
Refs: #30066

PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.