Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: iojs -> nodejs #3015

Closed
wants to merge 1 commit into from
Closed

configure: iojs -> nodejs #3015

wants to merge 1 commit into from

Conversation

pmq20
Copy link
Contributor

@pmq20 pmq20 commented Sep 23, 2015

Inconsistency between configure and node.cc.

image

image

@rvagg
Copy link
Member

rvagg commented Sep 23, 2015

good catch, lgtm

@thefourtheye
Copy link
Contributor

LGTM

@brendanashworth brendanashworth added the build Issues and PRs related to build files or the CI. label Sep 23, 2015
@pmq20
Copy link
Contributor Author

pmq20 commented Sep 23, 2015

changed commit message to "build" as subsystem.

@silverwind
Copy link
Contributor

LGTM

silverwind pushed a commit that referenced this pull request Sep 23, 2015
@pmq20 @silverwind
build: iojs -> nodejs of release-urlbase
76c80d4 
PR-URL: #3015
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

Thanks, landed in 76c80d4.

@silverwind silverwind closed this Sep 23, 2015
Fishrock123 pushed a commit that referenced this pull request Sep 25, 2015
@pmq20 @Fishrock123
build: iojs -> nodejs of release-urlbase
9e9bfa4 
PR-URL: #3015
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Sep 30, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pmq20 @rvagg @thefourtheye @silverwind @brendanashworth