Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.3.0 proposal #30774

Merged
merged 180 commits into from
Dec 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
180 commits
Select commit Hold shift + click to select a range
9e9e48b
src: use uv_async_t for WeakRefs
addaleax Nov 23, 2019
55c2ac7
crypto: remove redundant validateUint32 argument
tniessen Nov 21, 2019
20ee499
test: refactor test-dgram-multicast-set-interface-lo.js
Nov 18, 2019
19d192d
doc: fix a typo in a date for version 13.2.0
Nov 22, 2019
1916acb
src: fix signal handler crash on close
codebytere Nov 22, 2019
8ef629a
doc: simplify "is recommended" language in assert documentation
Trott Nov 20, 2019
e122d39
test: replace setTimeout with setImmediate in stream test
Trott Nov 20, 2019
ebba322
test: use arrow function for callback in stream test
Trott Nov 20, 2019
103d01e
test: remove string literal as message in strictEqual() in stream test
Trott Nov 20, 2019
081b4e2
test: move stream test to parallel
Trott Nov 20, 2019
106235f
test: move explanatory comment to expected location in file
Trott Nov 20, 2019
36671f9
test: add common.mustCall() to stream test
Trott Nov 20, 2019
f135c38
src,doc: add C++ internals documentation
addaleax Nov 19, 2019
3b169f1
http: improve performance caused by primordials
lrecknagel Nov 12, 2019
8256d38
http: destructure primordials in lib/_http_server.js
artmaks Nov 6, 2019
44f28ea
src: fix -Wsign-compare warnings
cjihrig Nov 20, 2019
4e5818a
repl: change var to let
obelaifa Nov 12, 2019
0285aa0
events: improve performance caused by primordials
antimonyGu Nov 19, 2019
850c2a7
fs: cover fs.opendir ERR_INVALID_CALLBACK
darky Nov 6, 2019
c50bbf5
readline: change var to let
dnlup Nov 12, 2019
f7ca7e6
http2: replace var with let/const
pc3b3r Nov 12, 2019
f8dfa2d
test: switch to object spread in common/benchmark.js
Nov 6, 2019
502173b
lib: replace var to let in cli_table.js
Jing19 Nov 12, 2019
017280e
net: replaced vars to lets and consts
nath1as Nov 12, 2019
01e0571
test: test cover cases when trace is empty
Nov 6, 2019
55fbe45
cluster: replace var by let in shared_handle.js
putxe Nov 12, 2019
d6a4488
test: dns utils replace var
ovhemert Nov 12, 2019
48fef42
lib: replace var with let/const
Nov 12, 2019
8a9ee48
test: change var to let in test-trace-events
jonchurch Nov 12, 2019
8ee27ff
fs: change var to let
alvarp Nov 12, 2019
1a2ed4a
http2: core.js replace var with let
DanielSchuech Nov 12, 2019
bdba03e
lib: change var to let
dktistakis Nov 12, 2019
0fd89cc
lib: replace var with let/const
Driesss Nov 12, 2019
7e7a816
test: replace var with let in pre_execution.js
Vunovati Nov 12, 2019
9dab32f
test: use spread instead of object.assign
19shubham11 Nov 12, 2019
d8da9da
test: changed var to let in module-errors
jrizza88 Nov 12, 2019
4b13bca
child_process: replace var with const/let in internal/child_process.js
lcamargof Nov 12, 2019
d277c37
lib: changed var to let
obelaifa Nov 12, 2019
2ecc735
test: use spread instead of Object.assign
dnlup Nov 12, 2019
6848bfb
http: replace var with let
Nov 12, 2019
e401e8c
test: change object assign to spread object
putxe Nov 12, 2019
7d98a59
doc: add note about debugging worker_threads
lundibundi Nov 22, 2019
708e67a
cluster: replace var with let
Nov 12, 2019
3c041ed
lib: use let instead of var
edspace Nov 12, 2019
d024630
lib: change var to let in stream_base_commons
marquicodes Nov 12, 2019
0b64e45
lib: main_thread_only change var to let
matijagaspar Nov 12, 2019
d194c0f
src: replaced var with let
Nov 12, 2019
dade906
test: code&learn var to let update
Nazaroni Nov 12, 2019
797b938
lib: replace var with let
Nov 12, 2019
5522467
tools: update ESLint to 6.7.1
cjihrig Nov 22, 2019
84f7b5c
tools: enable more eslint rules
cjihrig Nov 22, 2019
00f7cc6
doc: add note of caution about non-conforming streams
ronag Oct 9, 2019
426ca26
doc: document "Resume Build" limitation
richardlau Nov 22, 2019
d651c7d
test: test for minimum ICU version consistency
richardlau Nov 23, 2019
97e6273
test: use useful message argument in test function
Trott Nov 24, 2019
ffe3040
lib: adding perf notes js_stream_socket.js
ryanj Nov 12, 2019
60b17b4
test: change object assign by spread operator
putxe Nov 12, 2019
30ef8e4
http2: change var to let compact.js
MariaEmma Nov 12, 2019
3796885
lib: replace var with let/const
Tijl5 Nov 12, 2019
dae36a9
child_process: replace var with let/const
dnlup Nov 12, 2019
5c40b2f
process: replace vars in per_thread.js
EmaSuriano Nov 12, 2019
b18b056
lib: replace var w/ let
IAmEddieDean Nov 12, 2019
378c54f
cluster: replace vars in child.js
EmaSuriano Nov 12, 2019
56248a8
process: replace var with let/const
deadbeef84 Nov 12, 2019
18e9b56
util: use let instead of var for util/inspect.js
lmammino Nov 12, 2019
5120926
lib: replace var with let/const
jens-cappelle Nov 12, 2019
b545b91
lib: use let instead of var
19shubham11 Nov 12, 2019
329a821
doc: add explanation why keep var with for loop
lrecknagel Nov 12, 2019
d4b6170
test: dir class initialisation w/o handler
Nov 6, 2019
365f0ab
esm: data URLs should ignore unknown parameters
bfarias-godaddy Nov 22, 2019
949f2ad
test: move test-worker-prof to sequential
Trott Nov 24, 2019
70d6fa1
test: skip test-domain-error-types in debug mode temporariliy
Trott Nov 24, 2019
8ab18b6
doc: update AUTHORS list
devsnek Nov 26, 2019
e9f031c
doc: add 13 and 12 to previous versions
andrewhughes101 Nov 22, 2019
b67759a
doc,deps: document how to maintain ICU in Node.js
srl295 Nov 22, 2019
3d97883
doc: minor updates to releases.md
BethGriggs Nov 25, 2019
809a2b0
doc: fixup incorrect flag name reference
guybedford Nov 26, 2019
fcde497
doc: remove "this API is unstable" note for v8 serdes API
bruce-one Nov 24, 2019
fa1f87b
fs: rename rimraf's maxBusyTries to maxRetries
cjihrig Nov 25, 2019
612a3a2
fs: make rimraf default to 0 retries
cjihrig Nov 25, 2019
51bc379
fs: remove rimraf's emfileWait option
cjihrig Nov 25, 2019
f725953
fs: add retryDelay option to rimraf
cjihrig Nov 25, 2019
3475f9b
fs: add ENFILE to rimraf retry logic
cjihrig Nov 27, 2019
e92afd9
http2: replace direct array usage with struct for js_fields_
lundibundi Nov 18, 2019
092a3c2
http2: allow to configure maximum tolerated invalid frames
lundibundi Nov 18, 2019
5ecfd94
test: update and harden http2-reset-flood
lundibundi Nov 18, 2019
7d37bce
http2: make maximum tolerated rejected streams configurable
lundibundi Nov 18, 2019
1f10681
tty: truecolor check moved before 256 check
duncanhealy Nov 13, 2019
cc5875b
n-api: add missed nullptr check in napi_has_own_property
lundibundi Nov 24, 2019
0972fa3
test: add regression test for signal handler removal in exit
addaleax Nov 22, 2019
3769632
test: add mustCall() to test-inspector-contexts
Trott Nov 26, 2019
3571e13
test: check for session.post() errors in test-insepctor-context
Trott Nov 26, 2019
3e3ad39
test: remove destructuring from test-inspector-contexts
Trott Nov 26, 2019
a2f440d
test: add logging in case of infinite loop
Trott Nov 26, 2019
8171cef
n-api: implement napi_is_detached_arraybuffer
lundibundi Nov 23, 2019
9d8d2e1
src,doc: fix broken links
cjihrig Nov 26, 2019
d54432f
src: keep object alive in stream_pipe code
addaleax Nov 26, 2019
94357db
src: add more `can_call_into_js()` guards
addaleax Nov 26, 2019
bea2501
src: no SetImmediate from destructor in stream_pipe code
addaleax Nov 26, 2019
6c249c0
src: run native immediates during Environment cleanup
addaleax Nov 26, 2019
2cf8a7f
module: fix specifier resolution algorithm
pd4d10 Nov 22, 2019
8ec0d75
src: cleanup unused headers
alferpal Nov 7, 2019
6322611
inspector: properly shut down uv_async_t
addaleax Nov 19, 2019
89e2c71
tls: allow empty subject even with altNames defined
jasonmacgowan Sep 17, 2018
49458de
test: remove unused function argument from http test
Trott Nov 26, 2019
ecb902f
test: do not skip test-http-server-consumed-timeout
Trott Nov 26, 2019
00f532f
test: remove unnecessary common.platformTimeout() call
Trott Nov 26, 2019
a3b758d
test: move test-https-server-consumed-timeout to parallel
Trott Nov 26, 2019
aa01ebd
deps: V8: cherry-pick ca5b0ec
addaleax Nov 28, 2019
83861fb
test: revert 6d022c13
addaleax Nov 28, 2019
456d250
deps: V8: backport 93f189f19a03
targos Nov 27, 2019
d257448
deps: update llhttp to 2.0.1
indutny Nov 20, 2019
1d1d136
http: set socket.server unconditionally
addaleax Nov 20, 2019
30a4f68
child_process: document kill() return value
cjihrig Nov 26, 2019
0b0f023
tls: add memory tracking support to SSLWrap
addaleax Nov 19, 2019
7bd587e
src: use BaseObjectPtr to store SNI context
addaleax Nov 19, 2019
fc11db1
src: inline SetSNICallback
addaleax Nov 19, 2019
4affc30
crypto: automatically manage memory for ECDSA_SIG
tniessen Nov 25, 2019
80ada94
build: use Node.js instead of Node in configure
tniessen Nov 25, 2019
b470354
deps: patch V8 to 7.9.317.25
MylesBorins Nov 27, 2019
87136c9
doc: revise socket.connect() note
Trott Nov 27, 2019
1e7c567
doc: address nits for src/README.md
addaleax Nov 28, 2019
20dbce1
doc: avoid proposal syntax in code example
alexzherdev Nov 27, 2019
43e7857
doc: fix worker.resourceLimits type
dnalborczyk Nov 26, 2019
aca0119
doc: fix worker.resourceLimits indentation
dnalborczyk Nov 26, 2019
40b7621
doc: add missing 'added' versions to module.builtinModules
watson Nov 20, 2019
e8af569
buffer: release buffers with free callbacks on env exit
addaleax Nov 19, 2019
be9788b
n-api: detach external ArrayBuffers on env exit
addaleax Nov 19, 2019
099d3fd
test: port worker + buffer test to N-API
addaleax Nov 19, 2019
f37450f
dns: use length for building TXT string
addaleax Nov 27, 2019
63eb4fe
buffer: fix 6-byte writeUIntBE() range check
mscdex Nov 13, 2019
ba0115f
test:refactor createHook test
JenyMzo Nov 20, 2019
bccfd12
src: remove unused variable in node_dir.cc
gengjiawen Nov 5, 2019
be84cee
src: clean up node_file.h
addaleax Nov 18, 2019
6f313f9
http2: fix session memory accounting after pausing
Nov 27, 2019
bfcc914
doc,n-api: mark napi_detach_arraybuffer as experimental
legendecas Nov 28, 2019
ad9f737
doc: documenting a bit more FreeBSD case
devnexen Nov 8, 2019
8fcb450
doc: fixed a typo in process.md
Nov 6, 2019
4800b62
test: use arrow functions in addons tests
GaryGSC Oct 26, 2019
a25626c
doc: clarify IncomingMessage.destroy() description
XMB5 Nov 4, 2019
5a6f836
tools: add unified plugin changing links for html docs
Oct 12, 2019
cbd5026
doc: note that buf.buffer's contents might differ
strugee Sep 22, 2019
a4dfe3b
lib: flatten access to primordials
targos Nov 22, 2019
5ef4dce
lib: enforce use of Array from primordials
targos Nov 23, 2019
1040e72
util: fix inspection of errors with tampered name or stack property
BridgeAR Nov 21, 2019
6a0dd1c
util: fix .format() not always calling toString when it should be
BridgeAR Nov 9, 2019
c09e3de
lib: replace ArrayBuffer.isView by primordial ArrayBuffer
Kawacrepe Nov 27, 2019
ae2c7d0
lib: replace Date.now function by primordial DateNow
Tchoupinax Nov 27, 2019
892bde6
lib: enforce use of Boolean from primordials
targos Nov 28, 2019
5a9340d
lib: use static Number properties from primordials
targos Nov 27, 2019
de3a1c3
lib: enforce use of primordial Number
Sebastien-Ahkrin Nov 28, 2019
4cd4e7c
benchmark,doc,lib,test: prepare for padding lint rule
Trott Nov 28, 2019
941a91d
tools: enforce blank line between functions
Trott Nov 28, 2019
93707c4
test: increase coverage for trace_events.js
Trott Nov 28, 2019
0ba877a
deps: V8: cherry-pick 0dfd9ea51241
bcoe Nov 28, 2019
e968e26
stream: improve performance for sync write finishes
addaleax Nov 29, 2019
6257408
http: make maximum header size configurable per-stream or per-server
addaleax Nov 20, 2019
b91d22c
repl: fix referrer for dynamic import
coreyfarrell Nov 23, 2019
9ec53cf
wasi: introduce initial WASI support
cjihrig Sep 4, 2019
01ab031
test: remove unused callback argument
Trott Nov 29, 2019
d69b9b7
test: simplify forEach() usage
Trott Nov 29, 2019
1222be8
test: remove unused callback argument
Trott Nov 29, 2019
1918b4e
test: correct header length subtraction
Trott Nov 29, 2019
1e199ce
test: move test-http-max-http-headers to parallel
Trott Nov 29, 2019
e65ad86
src: change header file in node_stat_watcher.cc
aug2uag Dec 1, 2019
7aa1df7
tls: introduce ERR_TLS_INVALID_CONTEXT
Trott Nov 29, 2019
f46df0b
doc: update socket.bufferSize text
Trott Nov 30, 2019
a8002d9
doc: update README.md to fix active/maint times
mhdawson Nov 28, 2019
61af1fc
doc: update signature algorithm in release doc
MylesBorins Nov 26, 2019
19b31c1
doc: revise REPL uncaught exception text
Trott Nov 30, 2019
b5c7dad
test: fix test-benchmark-streams
Trott Dec 2, 2019
37c70ee
test: use arrow functions in async-hooks tests
GaryGSC Oct 26, 2019
3d302ff
doc: fix typographical error
Trott Nov 30, 2019
6a53152
build,win: add test-ci-native and test-ci-js
joaocgreis Nov 29, 2019
0aae502
build,win: propagate error codes in vcbuild
joaocgreis Nov 30, 2019
81d81a5
test: add an indicator `isIBMi`
dmabupt Nov 29, 2019
49e047f
test: add coverage for ERR_TLS_INVALID_PROTOCOL_VERSION
Trott Nov 30, 2019
6545314
build: add --without-node-code-cache configure option
joyeecheung Nov 26, 2019
648766b
build: do not build mksnapshot and mkcodecache for --shared
joyeecheung Nov 26, 2019
f5fe384
2019-12-03, Version 13.3.0 (Current)
BridgeAR Dec 3, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 7 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,14 @@ module.exports = {
'no-class-assign': 'error',
'no-confusing-arrow': 'error',
'no-const-assign': 'error',
'no-constructor-return': 'error',
'no-control-regex': 'error',
'no-debugger': 'error',
'no-delete-var': 'error',
'no-dupe-args': 'error',
'no-dupe-class-members': 'error',
'no-dupe-keys': 'error',
'no-dupe-else-if': 'error',
'no-duplicate-case': 'error',
'no-duplicate-imports': 'error',
'no-empty-character-class': 'error',
Expand Down Expand Up @@ -247,6 +249,7 @@ module.exports = {
'no-return-await': 'error',
'no-self-assign': 'error',
'no-self-compare': 'error',
'no-setter-return': 'error',
'no-shadow-restricted-names': 'error',
'no-tabs': 'error',
'no-template-curly-in-string': 'error',
Expand Down Expand Up @@ -279,6 +282,10 @@ module.exports = {
'one-var': ['error', { initialized: 'never' }],
'one-var-declaration-per-line': 'error',
'operator-linebreak': ['error', 'after'],
'padding-line-between-statements': [
'error',
{ blankLine: 'always', prev: 'function', next: 'function' },
],
'prefer-const': ['error', { ignoreReadBeforeAssign: true }],
'quotes': ['error', 'single', { avoidEscape: true }],
'quote-props': ['error', 'consistent'],
Expand Down
79 changes: 79 additions & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -2866,5 +2866,84 @@ akitsu-sanae <akitsu.sanae@gmail.com>
Minuk Park <parkm86@gmail.com>
Jim Schlight <jim@inspiredware.com>
Theotime Poisseau <theotime.poisseau@gmail.com>
Alex Zherdev <alex_zherdev@acl.com>
dev-313 <shekhawat.dev313@gmail.com>
Michael Perrotte <mike@npmjs.com>
Alexandre Ferrando <alferpal@gmail.com>
Loris Zinsou <lzinsou@protonmail.com>
Jizu Sun <jizu.sun@sap.com>
AshCripps <Ashley.Cripps@ibm.com>
garygsc <garygsc@gmail.com>
Patrick Housley <patrick.f.housley@gmail.com>
Artem Maksimov <temamaksimov@gmail.com>
Nolik <nolikfriendly@gmail.com>
palmires <palmires@example.com>
Vadim Gorbachev <bmsdave@gmail.com>
galina.prokofeva <g.k.prokofeva@gmail.com>
Nadya <nadin.ts@gmail.com>
PerfectPan <perfectpan325@gmail.com>
peze <cpj1106@gmail.com>
Vladislav Botvin <darkvlados@gmail.com>
Ilia Safronov <ilia.a.safronov@gmail.com>
Dmitriy Kikinskiy <di9@ytka.org>
telenord <nordtelecom.yandex.ru>
alexahdp <alexahdp@gmail.com>
Daniil Pletnev <divided.joy@gmail.com>
Grigoriy Levanov <glevanov@gmail.com>
Simon Schick <demwizzy@gmail.com>
Albert Wang <git@albertyw.com>
Kenza Houmani <khoumani@bloomberg.net>
mkdorff <mkdorff@outlook.com>
xefimx <xefimix@gmail.com>
garygsc <GaryGSC@users.noreply.github.com>
Susana Ferreira <ssncferreira@gmail.com>
Xavier Redondo <xavier.redondo@axa.com>
Duncan Healy <duncan.healy@gmail.com>
SoulMonk <fsoulmonk@gmail.com>
Kerry Mahne <kerry.mahne@gmail.com>
nathias <n@th1.as>
Nikolay Krashnikov <1090219@mail.ru>
daern91 <daniel_eriksson_8@hotmail.com>
JL Phillips <jlphillips@rms.com>
Jure Stepisnik <jure.stepisnik@tretton37.com>
Raoul Jaeckel <raoul.jaeckel@daimler.com>
Kyriakos Markakis <kyriakos@marqui.dev>
Guilherme Goncalves <gsg@ggoncalves.me>
Jesse O'Connor <jessekoconnor@gmail.com>
VinceOPS <vince.g.135@gmail.com>
David OLIVIER <davidolivier1337@gmail.com>
Maria Stogova <masha.stogova@gmail.com>
Taylor Gagne <tgagne@netsurion.com>
Kirlat <kirlat@yula.media>
Lucas Recknagel <lucas91@me.com>
Oliver Belaifa <oliver@belaifa.de>
guzhizhou <guzhizhou28@gmail.com>
Paolo Ceschi Berrini <pc3b3r@gmail.com>
Jing Lin <selinajinglin09@gmail.com>
poutch <damien.pucheu@hotmail.fr>
Tembrechts <Tim.embrechts@emby.ey>
Jon Church <me@jonchurch.com>
Àlvar Pérez <alvarperez92@gmail.com>
Daniel Schuech <dschuech@gmail.com>
Dimitris Ktistakis <dimitris@workable.com>
Dries Stelten <dries.stelten@telenet.be>
Vladimir Adamic <vladimir.adamic@gmail.com>
Shubham Chaturvedi <19shubham11@gmail.com>
Jamar Torres <Jetorres88@gmail.com>
Luis Camargo <luiska1993@gmail.com>
Herrmann, Rene R. (656) <rene.r.herrmann@daimler.com>
Semir Ajruli <ajruli.semir@gmail.com>
matijagaspar <matija.gaspar@gmail.com>
Aldo Ambrosioni <aldo.ambrosioni@accenture.com>
Nazar Malyy <nazar.malyy@gmail.com>
Dennis Saenger <node@mail.ds82.de>
ryan jarvinen <ryan.jarvinen@gmail.com>
Maria Emmanouil <emmanouil.maria@gmail.com>
Tijl Claessens <tijl.claessens@hotmail.com>
EmaSuriano <emanuel.suriano@gmail.com>
Chris Oyler <christopher.oyler@gmail.com>
Jesper Ek <deadbeef84@gmail.com>
Luciano <lucianomammino@gmail.com>
jens-cappelle <jens.jan.cappelle@gmail.com>

# Generated by tools/update-authors.js
9 changes: 7 additions & 2 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ platforms. This is true regardless of entries in the table below.
| macOS | x64 | >= 10.11 | Tier 1 | |
| SmartOS | x64 | >= 18 | Tier 2 | |
| AIX | ppc64be >=power7 | >= 7.2 TL02 | Tier 2 | |
| FreeBSD | x64 | >= 11 | Experimental | Downgraded as of Node.js 12 |
| FreeBSD | x64 | >= 11 | Experimental | Downgraded as of Node.js 12 <sup>[7](#fn7)</sup> |

<em id="fn1">1</em>: GCC 6 is not provided on the base platform, users will
need the
Expand Down Expand Up @@ -150,6 +150,10 @@ are provided. However, tests in our infrastructure only run on WoW64.
Furthermore, compiling on x86 Windows is currently considered Experimental and
may not be possible.

<em id="fn7">7</em>: The default FreeBSD 12.0 compiler is Clang 6.0.1, but
FreeBSD 12.1 upgrades to 8.0.1. Other Clang/LLVM versions are provided
via the system's package manager, including Clang 9.0.

### Supported toolchains

Depending on the host platform, the selection of toolchains may vary.
Expand Down Expand Up @@ -214,9 +218,10 @@ Supported platforms and toolchains change with each major version of Node.js.
This document is only valid for the current major version of Node.js.
Consult previous versions of this document for older versions of Node.js:

* [Node.js 13](https://github.com/nodejs/node/blob/v13.x/BUILDING.md)
* [Node.js 12](https://github.com/nodejs/node/blob/v12.x/BUILDING.md)
* [Node.js 10](https://github.com/nodejs/node/blob/v10.x/BUILDING.md)
* [Node.js 8](https://github.com/nodejs/node/blob/v8.x/BUILDING.md)
* [Node.js 6](https://github.com/nodejs/node/blob/v6.x/BUILDING.md)

## Building Node.js on supported platforms

Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V13.md#13.2.0">13.2.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V13.md#13.3.0">13.3.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.2.0">13.2.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.1.0">13.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.0.1">13.0.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.0.0">13.0.0</a><br/>
Expand Down
4 changes: 3 additions & 1 deletion COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@ Do not land any pull requests without passing (green or yellow) CI runs. If
there are CI failures unrelated to the change in the pull request, try "Resume
Build". It is in the left navigation of the relevant `node-test-pull-request`
job. It will preserve all the green results from the current job but re-run
everything else.
everything else. Start a fresh CI if more than seven days have elapsed since
the original failing CI as the compiled binaries for the Windows and ARM
platforms are only kept for seven days.

Some of the CI Jobs may require `GIT_REMOTE_REF` which is the remote portion
of Git refspec. To specify the branch this way `refs/heads/BRANCH` is used
Expand Down
3 changes: 3 additions & 0 deletions CPP_STYLE_GUIDE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# C++ Style Guide

See also the [C++ codebase README](src/README.md) for C++ idioms in the Node.js
codebase not related to stylistic issues.

## Table of Contents

* [Guides and References](#guides-and-references)
Expand Down
25 changes: 25 additions & 0 deletions LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -1503,3 +1503,28 @@ The externally maintained libraries used by Node.js are:
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
"""

- uvwasi, located at deps/uvwasi, is licensed as follows:
"""
MIT License

Copyright (c) 2019 Colin Ihrig and Contributors

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
"""
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,7 @@ test-all-valgrind: test-build
test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites.
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*

# CI_* variables should be kept synchronized with the ones in vcbuild.bat
CI_NATIVE_SUITES ?= addons js-native-api node-api
CI_JS_SUITES ?= default
ifeq ($(node_use_openssl), false)
Expand Down Expand Up @@ -745,7 +746,7 @@ $(LINK_DATA): $(wildcard lib/*.js) tools/doc/apilinks.js
$(call available-node, $(gen-apilink))

out/doc/api/%.json out/doc/api/%.html: doc/api/%.md tools/doc/generate.js \
tools/doc/html.js tools/doc/json.js tools/doc/apilinks.js | $(LINK_DATA)
tools/doc/markdown.js tools/doc/html.js tools/doc/json.js tools/doc/apilinks.js | $(LINK_DATA)
$(call available-node, $(gen-api))

out/doc/api/all.html: $(apidocs_html) tools/doc/allhtml.js \
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Looking for help? Check out the
each October.
* **LTS**: Releases that receive Long-term Support, with a focus on stability
and security. Every even-numbered major version will become an LTS release.
LTS releases receive 18 months of _Active LTS_ support and a further 12 months
LTS releases receive 12 months of _Active LTS_ support and a further 18 months
of _Maintenance_. LTS release lines have alphabetically-ordered codenames,
beginning with v4 Argon. There are no breaking changes or feature additions,
except in some special circumstances.
Expand Down
3 changes: 3 additions & 0 deletions benchmark/process/next-tick-breadth-args.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,19 @@ function main({ n }) {
if (j === n)
bench.end(n);
}

function cb2(arg1, arg2) {
j++;
if (j === n)
bench.end(n);
}

function cb3(arg1, arg2, arg3) {
j++;
if (j === n)
bench.end(n);
}

function cb4(arg1, arg2, arg3, arg4) {
j++;
if (j === n)
Expand Down
3 changes: 3 additions & 0 deletions benchmark/process/next-tick-depth-args.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function main({ n }) {
} else
bench.end(n);
}

function cb3(arg1, arg2, arg3) {
if (--counter) {
if (counter % 4 === 0)
Expand All @@ -33,6 +34,7 @@ function main({ n }) {
} else
bench.end(n);
}

function cb2(arg1, arg2) {
if (--counter) {
if (counter % 4 === 0)
Expand All @@ -46,6 +48,7 @@ function main({ n }) {
} else
bench.end(n);
}

function cb1(arg1) {
if (--counter) {
if (counter % 4 === 0)
Expand Down
11 changes: 8 additions & 3 deletions benchmark/streams/writable-manywrites.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,19 @@ const common = require('../common');
const Writable = require('stream').Writable;

const bench = common.createBenchmark(main, {
n: [2e6]
n: [2e6],
sync: ['yes', 'no']
});

function main({ n }) {
function main({ n, sync }) {
const b = Buffer.allocUnsafe(1024);
const s = new Writable();
sync = sync === 'yes';
s._write = function(chunk, encoding, cb) {
cb();
if (sync)
cb();
else
process.nextTick(cb);
};

bench.start();
Expand Down
2 changes: 2 additions & 0 deletions benchmark/timers/set-immediate-breadth-args.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ function main({ n }) {
});

function cb1(arg1) {}

function cb2(arg1, arg2) {}

function cb3(arg1, arg2, arg3) {}

bench.start();
Expand Down
2 changes: 2 additions & 0 deletions benchmark/timers/set-immediate-depth-args.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ function main({ n }) {
setImmediate(cb1, n);
}
}

function cb2(n, arg2) {
if (--n) {
if (n % 3 === 0)
Expand All @@ -31,6 +32,7 @@ function main({ n }) {
setImmediate(cb1, n);
}
}

function cb1(n) {
if (--n) {
if (n % 3 === 0)
Expand Down
3 changes: 3 additions & 0 deletions benchmark/timers/timers-breadth-args.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,19 @@ function main({ n }) {
if (j === n)
bench.end(n);
}

function cb2(arg1, arg2) {
j++;
if (j === n)
bench.end(n);
}

function cb3(arg1, arg2, arg3) {
j++;
if (j === n)
bench.end(n);
}

function cb4(arg1, arg2, arg3, arg4) {
j++;
if (j === n)
Expand Down
2 changes: 2 additions & 0 deletions benchmark/timers/timers-timeout-nexttick.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ function main({ n }) {
function cb() {
process.nextTick(counter);
}

function cb2() {
process.nextTick(counter);
}

function counter() {
count++;
if (count === n)
Expand Down
1 change: 1 addition & 0 deletions benchmark/timers/timers-timeout-pooled.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function main({ n }) {
if (count === n)
bench.end(n);
}

function cb2() {
count++;
if (count === n)
Expand Down
1 change: 1 addition & 0 deletions benchmark/timers/timers-timeout-unpooled.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function main({ n }) {
if (count === n)
bench.end(n);
}

function cb2() {
count++;
if (count === n)
Expand Down
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.20',
'v8_embedder_string': '-node.23',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion configure
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ del _
import sys
from distutils.spawn import find_executable

print('Node configure: Found Python {0}.{1}.{2}...'.format(*sys.version_info))
print('Node.js configure: Found Python {0}.{1}.{2}...'.format(*sys.version_info))
acceptable_pythons = ((3, 8), (3, 7), (3, 6), (3, 5), (2, 7))
if sys.version_info[:2] in acceptable_pythons:
import configure
Expand Down
Loading