Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: replace Symbol.toPrimitive to SymbolToPrimitive primordials #30905

Closed
wants to merge 1 commit into from
Closed

lib: replace Symbol.toPrimitive to SymbolToPrimitive primordials #30905

wants to merge 1 commit into from

Conversation

Sebastien-Ahkrin
Copy link
Contributor

@Sebastien-Ahkrin Sebastien-Ahkrin commented Dec 11, 2019 •
edited

Just replaced every Symbol.toPrimitive by SymbolToPrimitive in the lib/* folder
For this, i just have added SymbolToPrimitive in the import

const {
  SymbolToPrimitive,
} = primordials;

I hope this pull request will help you ! :P

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. os Issues and PRs related to the os subsystem. labels Dec 11, 2019
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27612/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27624/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27636/

@Trott
Copy link
Member

Trott commented Dec 14, 2019

Landed in e490b2c

@Trott Trott closed this Dec 14, 2019
Trott pushed a commit that referenced this pull request Dec 14, 2019
@Sebastien-Ahkrin @Trott
lib: replace Symbol.toPrimitive to SymbolToPrimitive primordials
e490b2c 
PR-URL: #30905
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Sebastien-Ahkrin @MylesBorins
lib: replace Symbol.toPrimitive to SymbolToPrimitive primordials
a326309 
PR-URL: #30905
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
lib: replace Symbol.toPrimitive to SymbolToPrimitive primordials
7c3ac42 
PR-URL: #30905
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
lib: replace Symbol.toPrimitive to SymbolToPrimitive primordials
3348fe4 
PR-URL: #30905
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Sebastien-Ahkrin @nodejs-github-bot @Trott @targos @cjihrig @BridgeAR