Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: improve prototype inspection using `inspect()` and `showHidden` #31113

Closed

Conversation

@BridgeAR
Copy link
Member

BridgeAR commented Dec 27, 2019

The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment was marked as outdated.

@Trott

This comment was marked as resolved.

Copy link
Member

Trott commented Dec 29, 2019

Typo in commit message: fath should be fast I think

@nodejs-github-bot

This comment was marked as outdated.

The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.
@BridgeAR BridgeAR force-pushed the BridgeAR:2019-12-27-fix-inspect-prototype branch from f6bbe0f to 5546d95 Dec 31, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jan 1, 2020
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 1, 2020

BridgeAR added a commit that referenced this pull request Jan 2, 2020
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Jan 2, 2020

Landed in 7babffb 🎉

@BridgeAR BridgeAR closed this Jan 2, 2020
BridgeAR added a commit that referenced this pull request Jan 3, 2020
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
@targos

This comment has been minimized.

Copy link
Member

targos commented Jan 14, 2020

This needs a backport or other previous PRs to be backported in order to land on v12.x-staging.

@BridgeAR BridgeAR deleted the BridgeAR:2019-12-27-fix-inspect-prototype branch Jan 20, 2020
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 20, 2020
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

PR-URL: nodejs#31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.