Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: suppress warning in src/node_env_var.cc #31136

Closed
wants to merge 1 commit into from

Conversation

@HarshithaKP
Copy link
Contributor

HarshithaKP commented Dec 30, 2019

Initialise the superclass object in the copy constructor of mapKVStore
Refs: #18983

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Initialise the superclass object in the copy constructor of mapKVStore
@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Dec 30, 2019
@lpinca
lpinca approved these changes Dec 30, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 2, 2020

Landed in 4614f64

@Trott Trott closed this Jan 2, 2020
Trott added a commit that referenced this pull request Jan 2, 2020
Initialise the superclass object in the copy constructor of mapKVStore

PR-URL: #31136
Refs: #18983
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Initialise the superclass object in the copy constructor of mapKVStore

PR-URL: #31136
Refs: #18983
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Initialise the superclass object in the copy constructor of mapKVStore

PR-URL: #31136
Refs: #18983
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.