Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: reland test refactoring #31755

Conversation

@BridgeAR
Copy link
Member

BridgeAR commented Feb 12, 2020

#31396 was reverted in #31722. The issue was that WRK is not able to handle decimal times (and the minimum possible time is one second) and the threads must not be higher than the number of connections.

I just reverted the revert and added a fixup commit to fix the actual issue. The commit message might be changed during landing?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@BridgeAR BridgeAR requested a review from addaleax Feb 12, 2020
@BridgeAR BridgeAR force-pushed the BridgeAR:2020-02-12-reland-benchmark-test-refactoring branch Feb 12, 2020
@BridgeAR BridgeAR requested review from Trott and sam-github Feb 12, 2020
@nodejs-github-bot

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Feb 12, 2020

benchmark/run.js Outdated Show resolved Hide resolved
@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Feb 13, 2020

@Trott
Trott approved these changes Feb 15, 2020
@addaleax addaleax removed the author ready label Mar 9, 2020
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Mar 9, 2020

This needs a rebase.

BridgeAR added 6 commits Feb 12, 2020
This reverts commit 5b0308c.
…rrors""

This reverts commit 4671d55.
…t option""

This reverts commit aa0a01b.
This reverts commit 7cfbc9f.
@BridgeAR BridgeAR force-pushed the BridgeAR:2020-02-12-reland-benchmark-test-refactoring branch to 778b2a6 Mar 9, 2020
@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 9, 2020

BridgeAR added a commit that referenced this pull request Mar 9, 2020
This reverts commit 5b0308c.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 9, 2020
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 9, 2020
This reverts commit aa0a01b.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 9, 2020
This reverts commit 7cfbc9f.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 9, 2020

Landed in 9e69d97...bb6125b 🎉

@BridgeAR BridgeAR closed this Mar 9, 2020
MylesBorins added a commit that referenced this pull request Mar 9, 2020
This reverts commit 5b0308c.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 9, 2020
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 9, 2020
This reverts commit aa0a01b.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 9, 2020
This reverts commit 7cfbc9f.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.