Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: non-enumerable 'Symbol(kCapture)' #31788

Closed
wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Feb 14, 2020

fix #31787

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the events Issues and PRs related to the events subsystem / EventEmitter. label Feb 14, 2020
@bnoordhuis
Copy link
Member

Have you run the benchmarks? I would expect this to introduce a performance regression.

@himself65 himself65 changed the title events: non-enumerable 'Symbol(kCapture)' [WIP] events: non-enumerable 'Symbol(kCapture)' Feb 14, 2020
@mscdex
Copy link
Contributor

mscdex commented Feb 14, 2020

IMO we shouldn't need to make any changes for the linked issue as I see util.inspect() output as being something for human consumption. Anyone relying on its output for the purposes of automated tests and such should look for better alternatives (and the issue submitter even admits this).

@himself65 himself65 changed the title [WIP] events: non-enumerable 'Symbol(kCapture)' events: non-enumerable 'Symbol(kCapture)' Feb 14, 2020
@himself65 himself65 closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String representation of EventEmitter changed in Node 12.16
4 participants