Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo preventing test from running #31931

Merged
merged 2 commits into from
Feb 26, 2020
Merged

test: fix typo preventing test from running #31931

merged 2 commits into from
Feb 26, 2020

Commits on Feb 26, 2020

  1. test: fix typo in common/index.js 

    All tests using enoughTestCpu checks are always having the checks come
back false due to a typo in common/index.js. Fix the typo.

PR-URL: nodejs#31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    fc68bf2 View commit details
    Browse the repository at this point in the history

  2. test: add documentation for common.enoughTestCpu 

    PR-URL: nodejs#31931
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    8824229 View commit details
    Browse the repository at this point in the history