Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13.x backport] stream: eos make const state const #32178

Closed
wants to merge 1 commit into from
Closed

[v13.x backport] stream: eos make const state const #32178

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 10, 2020 •
edited

PR-URL: #32031

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag requested a review from MylesBorins March 10, 2020 17:31
@ronag
stream: eos make const state const
18e5e53 
writable & readable is based on type and is not actual
state, treat them as such.

PR-URL: nodejs#32031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Backport-PR-URL: nodejs#32178
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Mar 10, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29702/

MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@ronag @MylesBorins
stream: eos make const state const
f263659 
writable & readable is based on type and is not actual
state, treat them as such.

Backport-PR-URL: #32178
PR-URL: #32031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins
Copy link
Member

landed in f263659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ronag @nodejs-github-bot @MylesBorins