-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v12.x backport] stream: sync stream unpipe resume #32264
Conversation
d56c5b2
to
0b1f537
Compare
@ronag can you also add |
@codebytere I did? |
a01fb4a
to
e5dc2fb
Compare
63a03d2
to
d577190
Compare
@ronag could you please rebase this against latest staging? |
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190 Backport-PR-URL: nodejs#32264 PR-URL: nodejs#31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
I went ahead and got a rebase done but was unable to push to the branch https://github.com/MylesBorins/node/tree/backport-31191-to-12.x |
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190 PR-URL: nodejs#31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#32264
0b1f537
to
1cdf6f6
Compare
Not sure what this means. Is there a setting I missed when creating this branch? |
This comes from a fork in an org not a personal repo so I don't think others can push to it. Looks like lots of failures so double checking that staging is still green 12.x-staging CI: https://ci.nodejs.org/job/node-test-commit/37126/ |
This comment has been minimized.
This comment has been minimized.
landed in 12253f8 |
pipe() ondata should not control flow state if cleaned up. Fixes: #31190 Backport-PR-URL: #32264 PR-URL: #31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #32264
PR-URL: #31191
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes