[v12.x backport] util: use a global symbol for util.promisify.custom
#32349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
util
codebytere
force-pushed
the
v12.x-staging
branch
from
a01fb4a
to
e5dc2fb
Compare
codebytere
force-pushed
the
v12.x-staging
branch
2 times, most recently
from
63a03d2
to
d577190
Compare
|
I got a rebase of this working but was unable to push to the branch. You can find it at https://github.com/MylesBorins/node/tree/backport/v12.x/lib/util/use-global-util-promisify-custom-symbol |
Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Fixes: nodejs#31647
PR-URL: nodejs#31672
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ExE-Boss
force-pushed
the
backport/v12.x/lib/util/use-global-util-promisify-custom-symbol
branch
from
e874d47
to
0a8c5c1
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Apr 2, 2020
Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Fixes: #31647
Backport-PR-URL: #32349
PR-URL: #31672
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
landed in 32c0449 |
|
@MylesBorins it's a very small addition but the original PR was semver-minor. This just landed on the v12.16.2 patch release though. |
ExE-Boss
deleted the
backport/v12.x/lib/util/use-global-util-promisify-custom-symbol
branch
|
@targos oof Do you think we should revert? |
|
We can talk about it in 5 minutes, but no I don't think we should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #31672 to Node v12.
It has already been backported to Node v13 as 975d6b0.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes