src: make fs functions handle pre-epoch timestamps #32408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in commit 9836cf5 ("lib: lazy instantiation of fs.Stats dates") without providing any rationale - that wasn't added until later, by someone else - and it doesn't look the least bit correct to me. It certainly makes an upcoming regression test fail because a timestamp in the deep past doesn't round-trip correctly, it's off by a fraction of a second. Refs: nodejs#32369
A wrong type cast prevented timestamps before 1970-01-01 from working with functions like `fs.stat()`. Fixes: nodejs#32369
nodejs-github-bot
added
the
lib / src
|
I wonder if there's another bug hiding somewhere... edit: edit2: the test mixes up assert.strictEqual(Y2K38_mtime, Y2K38_stats.mtime.getTime() / 1000);They should be the other way around: assert.strictEqual(Y2K38_stats.mtime.getTime() / 1000, Y2K38_mtime);I.e., edit3: opened #32420 to fix that. |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Mar 22, 2020
`actual` is the first argument, `expected` the second, but the test flipped them around and was producing confusing assertion messages as a result. Refs: nodejs#32408 (comment)
I might be mistaken about that because the soon-to-be-added libuv test |
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
`actual` is the first argument, `expected` the second, but the test flipped them around and was producing confusing assertion messages as a result. Refs: #32408 (comment) PR-URL: #32420 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
`actual` is the first argument, `expected` the second, but the test flipped them around and was producing confusing assertion messages as a result. Refs: #32408 (comment) PR-URL: #32420 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
`actual` is the first argument, `expected` the second, but the test flipped them around and was producing confusing assertion messages as a result. Refs: #32408 (comment) PR-URL: #32420 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
`actual` is the first argument, `expected` the second, but the test flipped them around and was producing confusing assertion messages as a result. Refs: #32408 (comment) PR-URL: #32420 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff
to
2935f72
Compare
|
Superseded by #43714. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A wrong type cast prevented timestamps before 1970-01-01 from working
with functions like
fs.stat().Fixes: #32369
The first commit is libuv/libuv#2747. This PR can't land (at least, not without the test failing) until libuv is upgraded.