stream: cleanup pipeline destroyer

[ronag]

Slightly cleans up the destroyer logic. Make readable and writable use similar logic.

i.e.

    if (!err && reading && !writing && stream.writable) {
      return callback();
    }

    if (!err && !reading && writing && stream.readable) {
      return callback();
    }

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/30508/

[rickyes]

Maybe merge writable and readable.

[ronag]

not sure I follow?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/30616/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/30677/ ✅

[mcollina]

lgtm

[BridgeAR]

if (!err) {
  if (reading) {
    if (!writing && stream.writable) {
      return callback();
    }
  } else if (writing && stream.readable) {
    return callback();
  }
}

[ronag]

I suppose this is a nit?

[ronag]

This might be redundant given #32966

[ronag]

closed in favor of #32968