Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-04-12 Node.js v10.20.1 'Dubnium' (LTS) Release #32768

Merged
merged 1 commit into from Apr 12, 2020
Merged

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Apr 10, 2020

2020-04-10, Version 10.20.1 'Dubnium' (LTS), @BethGriggs

Notable changes

Due to release process failures, Node.js v10.20.0 shipped with source
and header tarballs that did not properly match the final release
commit that was used to build the binaries. We recommend that Node.js
v10.20.0 not be used, particularly in any applications using native
add-ons or where compiling Node.js from source is involved.

Node.js v10.20.1 is a clean release with the correct sources and is
strongly recommended in place of v10.20.0.

Refs: #32755

@nodejs-github-bot nodejs-github-bot added meta v10.x labels Apr 10, 2020
BethGriggs added a commit that referenced this issue Apr 10, 2020
Notable changes:

Due to release process failures, Node.js v10.20.0 shipped with source
and header tarballs that did not properly match the final release
commit that was used to build the binaries. We recommend that Node.js
v10.20.0 not be used, particularly in any applications using native
add-ons or where compiling Node.js from source is involved.

Node.js v10.20.1 is a clean release with the correct sources and is
strongly recommended in place of v10.20.0.

PR-URL: #32768
@BethGriggs BethGriggs requested a review from Apr 10, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 10, 2020

targos
targos approved these changes Apr 10, 2020
@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Apr 10, 2020

Kicking off a build now - I think it makes sense break the 'avoid Friday releases' rule here if the build will complete in time.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 10, 2020

@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Apr 10, 2020

plinux is failing CI with:

18:13:08 WARNING: failed to autodetect C++ compiler version (CXX=g++-4.9)
18:13:08 WARNING: failed to autodetect C compiler version (CC=gcc-4.9)
18:13:08 ERROR: No acceptable C compiler found!
18:13:08 
18:13:08        Please make sure you have a C compiler installed on your system and/or
18:13:08        consider adjusting the CC environment variable if you installed
18:13:08        it in a non-standard prefix.
18:13:08 make: *** [build-ci] Error 1

@sam-github @nodejs/build

@targos
Copy link
Member

@targos targos commented Apr 10, 2020

@BethGriggs I'd just ignore that and start the release job

@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Apr 10, 2020

@targos, I just checked and the release machine is failing with the same similar error. I know plinux machine updates were due to happen around now, ready for v14.x.

Edit: link - https://ci-release.nodejs.org/job/iojs+release/nodes=centos7-ppcle-release-64/5885/console

19:34:07 make[2]: g++-4.9: Command not found
19:34:07 make[2]: *** [/home/iojs/build/ws/out/Release/torque] Error 127
19:34:07 make[2]: *** Waiting for unfinished jobs....
19:34:07 rm dc0aa0889910e117de695888bc7126f9a7a14634.intermediate
19:34:07 make[2]: Leaving directory `/home/iojs/build/ws/out'
19:34:07 make[1]: *** [node] Error 2
19:34:07 make[1]: Leaving directory `/home/iojs/build/ws'

@targos
Copy link
Member

@targos targos commented Apr 10, 2020

@sam-github this could be related to the recent devtoolset changes?

@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Apr 10, 2020

All other release builds look good

I don't think it's likely (or a reasonable expectation) that we'll get the machines fixed up on a public holiday. I'll keep checking back in over this evening and the weekend to see if anything has changed. Otherwise, Monday is looking more likely.

EDIT: nodejs/build#2282 needs to land first also.

@richardlau
Copy link
Member

@richardlau richardlau commented Apr 10, 2020

nodejs/build#2285 should fix compiler selection on pLinux.

cc @nodejs/build

@sam-github
Copy link
Contributor

@sam-github sam-github commented Apr 10, 2020

nodejs/build#2285 landed, hope it'll fix this, thanks for the PR @richardlau

@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Apr 10, 2020

I can confirm the PR fixed the issue and ppcle builds are complete. Thanks @richardlau, @sam-github

(nodejs/build#2282 still in progress)

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 10, 2020

@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Apr 10, 2020

It looks like this will not be ready to promote today UTC. I can check back over the weekend but it may make sense to leave it until Monday.

@nodejs/releasers (and any others with an opinion) thoughts on pushing this out, if possible:

  1. On a weekend (🚀)
  2. Leaving until Monday AM (👀)

Notable changes:

Due to release process failures, Node.js v10.20.0 shipped with source
and header tarballs that did not properly match the final release
commit that was used to build the binaries. We recommend that Node.js
v10.20.0 not be used, particularly in any applications using native
add-ons or where compiling Node.js from source is involved.

Node.js v10.20.1 is a clean release with the correct sources and is
strongly recommended in place of v10.20.0.

PR-URL: #32768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants