Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] Backport stream: fix readable state awaitDrain increase in recursion #33056

Closed
wants to merge 1 commit into from
Closed

[v12.x] Backport stream: fix readable state awaitDrain increase in recursion #33056

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 25, 2020

Backport of #27572

@nodejs/streams

@abbshr @targos
stream: fix readable state awaitDrain increase in recursion
b440cb1 
PR-URL: nodejs#27572
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@nodejs-github-bot nodejs-github-bot added stream Issues and PRs related to the stream subsystem. v12.x labels Apr 25, 2020
mcollina
mcollina approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30987/

targos pushed a commit that referenced this pull request Apr 28, 2020
@abbshr @targos
stream: fix readable state awaitDrain increase in recursion
c8b4ab0 
PR-URL: #27572
Backport-PR-URL: #33056
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos
Copy link
Member Author

targos commented Apr 28, 2020

Landed in c8b4ab0

@targos targos closed this Apr 28, 2020
@targos targos deleted the backport-stream branch April 28, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@targos @nodejs-github-bot @mcollina @benjamingr @abbshr