Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] n-api: backport ArrayBuffer detaching APIs #33061

Closed
wants to merge 3 commits into from
Closed

[v10.x] n-api: backport ArrayBuffer detaching APIs #33061

wants to merge 3 commits into from

Commits on Jul 1, 2020

  1. n-api: add napi_detach_arraybuffer 

    As ArrayBuffer#detach is an ecma spec operation
([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
it might be good to have it in N-API.

Fixes nodejs#29674

PR-URL: nodejs#29768
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    @legendecas
    legendecas committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    2243556 View commit details
    Browse the repository at this point in the history

  2. n-api: implement napi_is_detached_arraybuffer 

    This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: nodejs#29955

PR-URL: nodejs#30613
Fixes: nodejs#29955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @lundibundi @legendecas
    lundibundi authored and legendecas committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    8ec28f5 View commit details
    Browse the repository at this point in the history

  3. doc,n-api: mark napi_detach_arraybuffer as experimental 

    As its actual release stage.

PR-URL: nodejs#30703
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    @legendecas
    legendecas committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    5ba1e7f View commit details
    Browse the repository at this point in the history