doc: add missing deprecation note #33203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
added
http
4 tasks
ronag
added a commit
to nxtedition/node
that referenced
this pull request
May 1, 2020
`socket.connect` is subtly broken due to timing and _undestroy issues. Discourage usage and ask users to instead create a new socket instance. Refs: nodejs#33203
ronag
changed the title
BridgeAR
approved these changes
May 3, 2020
BridgeAR
added
the
author ready
addaleax
approved these changes
May 3, 2020
juanarbol
approved these changes
May 3, 2020
|
@ronag CI is not longer required for docs-only changes, it is ok to land with green GitHub actions. :) |
ronag
added a commit
that referenced
this pull request
May 4, 2020
PR-URL: #33203 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
|
Landed in 36b4c56 |
targos
pushed a commit
that referenced
this pull request
May 4, 2020
PR-URL: #33203 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing section in deprecation
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes