Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write #33490

Closed
wants to merge 3 commits into from
Closed

[v14.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write #33490

wants to merge 3 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented May 20, 2020 •
edited by ronag

Don't throw errors on Uint8Arrays and added test for all
valid types.

PR-URL: #33155
Fixes: #33379
Refs: #29829
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Zeyu Yang himself65@outlook.com
Reviewed-By: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v14.x labels May 20, 2020
@rexagod
http: don't throw on Uint8Arrays for http.ServerResponse#write
4732f15 
Don't throw errors on Uint8Arrays and added test for all
valid types.

Backport-PR-URL: nodejs#33490
PR-URL: nodejs#33155
Fixes: nodejs#33379
Refs: nodejs#29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rexagod rexagod changed the title http: don't throw on Uint8Arrays for http.ServerResponse#write [v12.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write May 20, 2020
@rexagod rexagod changed the title [v12.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write [v14.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write May 20, 2020
@rexagod
Copy link
Member Author

rexagod commented May 20, 2020 •
edited

Backport-PR-URL specified in rexagod@4732f15 (I was unable to trigger builds since I do not have the permission to do so, so I'm specifying the commit here, which is the same that that was force-pushed above).

@BridgeAR
Copy link
Member

@nodejs/http @ronag PTAL

ronag
ronag reviewed May 30, 2020
View reviewed changes
lib/_http_outgoing.js Outdated Show resolved Hide resolved
ronag
ronag requested changes May 30, 2020
View reviewed changes
Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contains unrelated semver major changes. Please remove those.

@rexagod
Copy link
Member Author

rexagod commented May 30, 2020

Made similar changes for v12.x backport as well.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31672/

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 31, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31797/

@nodejs nodejs deleted a comment from nodejs-github-bot Jun 27, 2020
@codebytere
Copy link
Member

Landed in feb6e1f

@codebytere codebytere closed this Jun 27, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@rexagod @codebytere
http: don't throw on Uint8Arrays for http.ServerResponse#write
feb6e1f 
Don't throw errors on Uint8Arrays and added test for all
valid types.

Backport-PR-URL: #33490
PR-URL: #33155
Fixes: #33379
Refs: #29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jun 28, 2020
Open
Open
Open
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@rexagod @codebytere
http: don't throw on Uint8Arrays for http.ServerResponse#write
1e6a049 
Don't throw errors on Uint8Arrays and added test for all
valid types.

Backport-PR-URL: #33490
PR-URL: #33155
Fixes: #33379
Refs: #29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 1, 2020
Open
Open
This was referenced Jul 3, 2020
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@BethGriggs BethGriggs BethGriggs left review comments

@codebytere codebytere codebytere approved these changes

@ronag ronag ronag approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rexagod @BridgeAR @nodejs-github-bot @codebytere @addaleax @ronag @BethGriggs