Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky fs-construct test #33625

Closed
wants to merge 1 commit into from
Closed

test: fix flaky fs-construct test #33625

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented May 28, 2020

Fixes: #33607

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 28, 2020
@ronag
Copy link
Member Author

ronag commented May 28, 2020 •
edited
Loading

Stress: https://ci.nodejs.org/job/node-stress-single-test/79/ ✅

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 28, 2020 •
edited by ronag
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31614/ ✅

@ronag
Copy link
Member Author

ronag commented May 28, 2020

There was a dependency in timing between two tests.

@richardlau
Copy link
Member

If the CI's and stress come back green I propose fast tracking this.

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2020
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 30, 2020
@BridgeAR
Copy link
Member

Landed in b0b268f

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 30, 2020
@ronag @BridgeAR
test: fix flaky fs-construct test
b0b268f 
Fixes: nodejs#33607

PR-URL: nodejs#33625
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR closed this May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky test-fs-stream-construct test
6 participants
@ronag @nodejs-github-bot @richardlau @BridgeAR @addaleax @benjamingr