Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: rename error-serdes for consistency #33793

Merged
merged 1 commit into from
Jun 23, 2020
Merged

internal: rename error-serdes for consistency #33793

merged 1 commit into from
Jun 23, 2020

Conversation

evanlucas
Copy link
Contributor

@evanlucas evanlucas commented Jun 8, 2020 •
edited
Loading

All other JavaScript files in lib use snake case, so make this
one consistent.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. worker Issues and PRs related to Worker support. labels Jun 8, 2020
devsnek
devsnek approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31781/

This was referenced Jun 9, 2020
Open
Open
@evanlucas evanlucas self-assigned this Jun 23, 2020
@evanlucas
internal: rename error-serdes for consistency
f6dbba8 
All other JavaScript files in lib use snake case, so make this
one consistent.

PR-URL: nodejs#33793
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@evanlucas evanlucas closed this Jun 23, 2020
@evanlucas evanlucas deleted the node-consistency branch June 23, 2020 16:36
@evanlucas evanlucas merged commit f6dbba8 into nodejs:master Jun 23, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@evanlucas @codebytere
internal: rename error-serdes for consistency
c9489f2 
All other JavaScript files in lib use snake case, so make this
one consistent.

PR-URL: #33793
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@evanlucas @codebytere
internal: rename error-serdes for consistency
34c84c0 
All other JavaScript files in lib use snake case, so make this
one consistent.

PR-URL: #33793
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 27, 2020
@evanlucas @addaleax
internal: rename error-serdes for consistency
1c8da57 
All other JavaScript files in lib use snake case, so make this
one consistent.

PR-URL: #33793
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@evanlucas @addaleax
internal: rename error-serdes for consistency
4a2accb 
All other JavaScript files in lib use snake case, so make this
one consistent.

PR-URL: #33793
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

Assignees

@evanlucas evanlucas

Labels
build Issues and PRs related to build files or the CI. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@evanlucas @nodejs-github-bot @addaleax @benjamingr @lpinca @cjihrig @devsnek