Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unnecessary calculation in base64.h #33839

Closed
wants to merge 1 commit into from
Closed

src: remove unnecessary calculation in base64.h #33839

wants to merge 1 commit into from

Conversation

sapics
Copy link
Contributor

@sapics sapics commented Jun 11, 2020

This PR removes unnecessary calculation in base64.h.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jun 11, 2020
@sapics sapics force-pushed the src/simplify-base64 branch 2 times, most recently from 28913ae to 82f408b Compare June 11, 2020 06:34
yashLadha
yashLadha requested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@yashLadha yashLadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

src/base64.h Outdated Show resolved Hide resolved
src/base64.h Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31828/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31835/

@github-actions github-actions bot mentioned this pull request Jun 18, 2020
Open
18 tasks
@addaleax
Copy link
Member

Landed in a80000e

@addaleax addaleax closed this Jun 25, 2020
addaleax pushed a commit that referenced this pull request Jun 25, 2020
@sapics @addaleax
src: remove unnecessary calculation in base64.h
a80000e 
PR-URL: #33839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@sapics sapics deleted the src/simplify-base64 branch June 25, 2020 16:38
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@sapics @codebytere
src: remove unnecessary calculation in base64.h
74f4aae 
PR-URL: #33839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@sapics @codebytere
src: remove unnecessary calculation in base64.h
ced68bf 
PR-URL: #33839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@sapics @codebytere
src: remove unnecessary calculation in base64.h
ee02d22 
PR-URL: #33839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
@sapics @codebytere
src: remove unnecessary calculation in base64.h
69f9629 
PR-URL: #33839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@sapics @codebytere
src: remove unnecessary calculation in base64.h
1bfa597 
PR-URL: #33839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@tniessen tniessen tniessen approved these changes

@devnexen devnexen devnexen approved these changes

@yashLadha yashLadha yashLadha approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sapics @nodejs-github-bot @addaleax @jasnell @tniessen @devnexen @yashLadha